Commit graph

1268 commits

Author SHA1 Message Date
Benjamin Staneck
dba177e1d1 unset keybinds with arrows on Windows
Fix #2873
2019-10-10 22:07:44 +02:00
Raz Friman
6039acd7a9 Update Electron to v6 (#3785)
* 3.0.0

* 3.0.2

* Save

* Save

* Upgrade yarn lock packages

* update node-gyp and node-pty

* update travis and appveyor to node 12

* appveyor is outdated as always

* update travis to xenial

* update node-pty@0.9.0-beta26

* update yarn.lock

* update electron to 6.0.8

* move node-pty to the correct package.json

* Fix linting failure

* Update yarn lockfile to try to fix appveyor build

* Remove unnecessary changes from package.json

* Try to fix appveyor by using a newer image

* Fix linting after my last change

* update electron to 6.0.9

* install windows-build-tools on appveyor

* fix syntax

* switch back to 2017 image

* remove old resolutions field

* revert accidental version change

* update electron to 6.0.11 and electron-rebuild to 1.8.6

* downgrade yarn to 1.18

until this issue is resolved https://github.com/yarnpkg/yarn/issues/7584

* update node-gyp to 6.0.0 and generate a fresh yarn lockfile

* update react and a few other dependencies

* fix lint

* this should actually be electron-builder, I think!

* update a few dependencies

* change to electron-store

electron-config was renamed to electron-store a while ago

* update xterm to v4.1.0 and ora to 4.0.2

* move pify to app/package.json

* TODO: Revert maybe. Throw a fit on every change to maybe fix the resizing issues

* a

* fix react ref problem

* fix split view focus problem

* remove the unnecessary fit

* remove the init col and row

* fix the problem that cannot show about hyper

* update electron to 6.0.12

* fix lint

* add more todos for componentWillReceiveProps deprecation

* update babel and plugins


Co-authored-by: Juan Campa <juancampa@gmail.com>
Co-authored-by: Benjamin Staneck <staneck@gmail.com>
Co-authored-by: ivan <ivanwonder@outlook.com>
2019-10-10 21:20:26 +02:00
Gaby
ab0c8fe13f Add support for font ligatures via xterm-addon-ligatures - Clos… (#3853)
* Add support for font ligatures via xterm-addon-ligatures

* Add disableLigatures config option, defaults to false

* Fix lint issue
2019-10-09 22:23:55 +02:00
Lukas Geiger
ff479fdfb1 ⬆️ xterm@4.1.0
I quickly tested this upgrade and haven't seen any problems so far on macOS.
2019-10-09 22:12:14 +02:00
Labhansh Agrawal
01e485f9a7 use cpy to copy files 2019-10-09 00:32:48 +02:00
Labhansh Agrawal
25cb25933b Linting and concurrently color 2019-10-08 21:42:51 +02:00
Labhansh Agrawal
89985fb6ab Remove forktschecker, tsc handles this 2019-10-08 21:42:51 +02:00
Labhansh Agrawal
95fccb8880 Fix yarn install error 2019-10-08 21:42:51 +02:00
Labhansh Agrawal
21072fb1f0 Use concurrently to run tsc watch, Add target to build config 2019-10-08 21:42:51 +02:00
Labhansh Agrawal
6a87ab4597 Rename compiled_app to target and add target in eslintignore 2019-10-08 21:42:51 +02:00
Labhansh Agrawal
7874fa813a add setup to compile ts files to compiled_app folder 2019-10-08 21:42:51 +02:00
Donald Green
f07963f930 Bug fixes for bell configuration (#3850)
* 1. Restored the ability to turn the "bell" sound on and off using the "bell" config parameter.
2. Restored the ability to change the bell sound by providing a URL. These changes allow for a web url or local absolute file path to an audio file.

The goal with these changes was to fix the issue causing the bell to never sound due to a difference in the underlying terminal emulators configurations from the previous one. While in the area, also decided to make sure that the sound can be changed by supplying a web url to an audio file or an absolute path to an audio file within the local machine

* Code style changes

* Code style changes

* 1. More code style changes

* 1. Spacing changes to try and abide by the linter

* 1. Applied all suggested changes by eslint

* 1. Removed functionality to specify a remote url to set a sound file for the bell sound. The amount of effort for handling when there is no internet connection, queuing and so forth wasn't worth keeping the feature. It is likely that the url could be used to download the file in which the user would be able to specify the file path tho this download file.
2. Created a new property that gets passed down from the terms container all the way to the individual term. We want to be able to evaluate if the bellSoundURL has changed to determine if we really need to read the sound file.
3. Moved logic to read the audio file into the main process. Setup a new action in the 'actions/ui' that will update the bell sound when it is finished and ready. This should prevent blocking the terminal from loading and thus increasing loading times.

* 1. Modified the file reading method to be more generic to increase reusability.
2. Updated the "arrBuf2Base64" method to utilize the node Buffer class which helped to reduce some complexity and seems to run more efficiently.
3. Removed the CONFIG_ASYNC action and reducer in favor of reusing CONFIG_RELOAD when the process is finished reading the file for the bell sound. In order to achieve this, we had to merge the config from "config.getConfig()" method with the "bellSound" property before dispatching to "reloadConfig".

* 1. Removed reference to now removed method

* 1. Removed the arrBuf2Base64 as it seemed unnecessary now that the function would be reduced to a single line. Moved the one-liner into file.js. Removed references to arrBuf2Base64 method.
2. Refactored the logic that handles reloading the config when it has been updated to fix an issue that would set the bell sound back to the default sound when the config is saved without changing the value of "bellSoundURL". Setup now to either read file and reload the config, or reuse the "bellSound" value saved in state and reload the config. This removes an inefficiency with the reloadConfig being dispatched twice when "bellSoundURL" has changed as well.

* 1. Removed a file that contained a single function, referenced in only one place that is performing a fairly simple task.
2. Updated the "getBase64FileData" method to use "Buffer.from()" instead of "Buffer()" due to messages stating that "Buffer()" is deprecated due to security and usability issues.

* Adjustments and regression issues fixed

1. Updated the default config file to better explain the supported options for the "bell" config property.
2. Rearranged the bellSoundURL default property to make it easier to find should one decide to change the bell sound.
3. Typos fixed in comments.
4. Update fetchFileData to utilize the configData provided as function argument. There appeared to be no reason to reference different sources of config data within the same method.

* 1. Removed the "BELL_STYLE" constant since it was only being used in one place.
2. Updated comment block to accurately reflect the current logic and made the comment much more concise.

* 1. Add null safety check on `configInfo.bell` if the config file does not contain this property.
2. Default bellSound to null if the file specified by the filepath in `configInfo.bellSoundUrl` failed to be read. This helps prevent a repeated error being thrown by the xterm instance.
3. Updated `term.js` to use componentDidUpdate in place of the UNSAFE lifcycle method `componentWillReceiveProps`. I found that this unsafe lifecycle was never being fired, which lead to the terminal never responding to configuration changes. Without this change, the custom bell sound was never being loaded into the xterm instance.
2019-10-08 17:13:35 +02:00
Benjamin Staneck
2cc4c9e1ef
Update xterm to v4 (#3830)
* update xterm to 4

* add back webGL addon

* remove ligatures xterm addon, unused atm and does not work with webGL renderer

* update node-pty

* more work on trying to get xterm4 to work

* update xterm to 4.0.2

* move where xterm addon props are assigned

* more updates

* only load webgl addon if webgl is enabled

* fix search function

* remove rendererType setting, the xterm addon does this for us

* use xcode 10.3 on circleci

* fix typo

* revert node-pty bump for now

* use stable versions of the xterm plugins

* fix focus listener

* add windowsMode prop

* move webGL check

* apply tweaks by @GitSquared

* fix resizing issue

* Revert "fix resizing issue"

This reverts commit fce3780b038d69378f63bdfbfa613f20130fad34.

* apply review suggestions

* change so all addons have separate instances for each terminal

* update yarn-standalone to 1.19

* fix resize problem of split view

by @ivanwonder

* apply review feedback

* fix lint

* add name and version to package.json

* address review feedback

* more review feedback
2019-10-06 20:51:56 +02:00
Kaushik
19644f3fa2 Adding logic to support working directory config (#3769)
* #3000: Adding logic to support working directory config

* #3000: Removing unused import

* #3000: Removing extra space
2019-10-04 22:27:58 +02:00
Andrea Maugars
76eff24484 Document that plugins can require Electron 2019-10-03 23:52:10 +02:00
Labhansh Agrawal
6e1f6f2b5e eslint config small fix (#3844)
removed babel parser override config from prettier, it should use typescript parser instead
2019-10-03 09:24:00 +02:00
Benjamin Staneck
850c66d1b6 run linter 2019-10-03 04:04:43 +02:00
Labhansh Agrawal
b52d8152bf Upgrade eslint to v6 and add TypeScript linting (#3843)
* Upgrade eslint to v6 and add TypeScript linting

* Fix pr checks


Co-authored-by: Benjamin Staneck <Stanzilla@users.noreply.github.com>
2019-10-03 02:56:50 +02:00
Joseph Amis
25fc964ae8 added extra colors to color palette (#3842) 2019-10-03 02:54:29 +02:00
Donald Green
5d7142c2df Return of the Bell (#2938)
* 1. Restored the ability to turn the "bell" sound on and off using the "bell" config parameter.
2. Restored the ability to change the bell sound by providing a URL. These changes allow for a web url or local absolute file path to an audio file.

The goal with these changes was to fix the issue causing the bell to never sound due to a difference in the underlying terminal emulators configurations from the previous one. While in the area, also decided to make sure that the sound can be changed by supplying a web url to an audio file or an absolute path to an audio file within the local machine

* Code style changes

* Code style changes

* 1. More code style changes

* 1. Spacing changes to try and abide by the linter

* 1. Applied all suggested changes by eslint

* 1. Removed functionality to specify a remote url to set a sound file for the bell sound. The amount of effort for handling when there is no internet connection, queuing and so forth wasn't worth keeping the feature. It is likely that the url could be used to download the file in which the user would be able to specify the file path tho this download file.
2. Created a new property that gets passed down from the terms container all the way to the individual term. We want to be able to evaluate if the bellSoundURL has changed to determine if we really need to read the sound file.
3. Moved logic to read the audio file into the main process. Setup a new action in the 'actions/ui' that will update the bell sound when it is finished and ready. This should prevent blocking the terminal from loading and thus increasing loading times.

* 1. Modified the file reading method to be more generic to increase reusability.
2. Updated the "arrBuf2Base64" method to utilize the node Buffer class which helped to reduce some complexity and seems to run more efficiently.
3. Removed the CONFIG_ASYNC action and reducer in favor of reusing CONFIG_RELOAD when the process is finished reading the file for the bell sound. In order to achieve this, we had to merge the config from "config.getConfig()" method with the "bellSound" property before dispatching to "reloadConfig".

* 1. Removed reference to now removed method

* 1. Removed the arrBuf2Base64 as it seemed unnecessary now that the function would be reduced to a single line. Moved the one-liner into file.js. Removed references to arrBuf2Base64 method.
2. Refactored the logic that handles reloading the config when it has been updated to fix an issue that would set the bell sound back to the default sound when the config is saved without changing the value of "bellSoundURL". Setup now to either read file and reload the config, or reuse the "bellSound" value saved in state and reload the config. This removes an inefficiency with the reloadConfig being dispatched twice when "bellSoundURL" has changed as well.

* 1. Removed a file that contained a single function, referenced in only one place that is performing a fairly simple task.
2. Updated the "getBase64FileData" method to use "Buffer.from()" instead of "Buffer()" due to messages stating that "Buffer()" is deprecated due to security and usability issues.

* Adjustments and regression issues fixed

1. Updated the default config file to better explain the supported options for the "bell" config property.
2. Rearranged the bellSoundURL default property to make it easier to find should one decide to change the bell sound.
3. Typos fixed in comments.
4. Update fetchFileData to utilize the configData provided as function argument. There appeared to be no reason to reference different sources of config data within the same method.

* 1. Removed the "BELL_STYLE" constant since it was only being used in one place.
2. Updated comment block to accurately reflect the current logic and made the comment much more concise.
2019-10-03 02:08:40 +02:00
Labhansh Agrawal
5158417eb0 fix search addon import (#3833) 2019-09-25 09:40:50 -04:00
Brandon Lee Dring
5bc8e0b1e8 Feat/text search (#3075)
* Added persistent text box search

* Toggle search box now working

* Restyled search box

* Linter and bug squashing

* Added multi OS hotkey support

* PR changes as requested

* Added ability to use escape button to close search field

* Woops forgot key mapping on non mac platforms

* fixed bug where escape would open up search window

* Removal of unused vars that died in conflict
2019-09-23 19:37:22 +02:00
ivanwonder
67a1fc4dbb support config 'useConpty' 2019-09-23 19:32:12 +02:00
ivanwonder
b890cc23d1 fix: can not open hyper by the cli;
window freezes when I try to close it
2019-09-23 19:32:12 +02:00
Rongjian Zhang
c0571348f8 Add examples of Cygwin and Git Bash 2019-09-23 19:25:43 +02:00
Sam D
88da6cd3d9 fix/remove indented empty lines 2019-09-23 19:23:41 +02:00
Sam D
af68171528 Fix middle mouse click tab close (#2230) 2019-09-23 19:23:41 +02:00
Labhansh Agrawal
8524d37f9e Port array.js and file.js to typescript 2019-09-23 17:55:53 +02:00
Labhansh Agrawal
b9ed180f27 Setup TypeScript 2019-09-23 17:55:53 +02:00
Labhansh Agrawal
6da86bb0e8 Upgrade to Babel7 2019-09-23 17:55:53 +02:00
Labhansh Agrawal
6c4a064f22 Upgrade to Webpack4 2019-09-23 17:55:53 +02:00
Benjamin Staneck
ec259be982 Revert "switch to open (#3788)"
This reverts commit 84bab83e88.
2019-09-11 05:22:19 +02:00
dependabot[bot]
bc8207f0b0 Bump tar from 2.2.1 to 2.2.2
Bumps [tar](https://github.com/npm/node-tar) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Commits](https://github.com/npm/node-tar/compare/v2.2.1...v2.2.2)

Signed-off-by: dependabot[bot] <support@github.com>
2019-09-11 05:08:30 +02:00
dependabot[bot]
7012110be4 Bump sshpk from 1.13.1 to 1.16.1
Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1.
- [Release notes](https://github.com/joyent/node-sshpk/releases)
- [Commits](https://github.com/joyent/node-sshpk/compare/v1.13.1...v1.16.1)

Signed-off-by: dependabot[bot] <support@github.com>
2019-09-11 04:44:23 +02:00
dependabot[bot]
25a7465ccb Bump fstream from 1.0.11 to 1.0.12
Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12.
- [Release notes](https://github.com/npm/fstream/releases)
- [Commits](https://github.com/npm/fstream/compare/v1.0.11...v1.0.12)

Signed-off-by: dependabot[bot] <support@github.com>
2019-09-11 04:29:42 +02:00
dependabot[bot]
be4c783714 Bump macaddress from 0.2.8 to 0.2.9
Bumps [macaddress](https://github.com/scravy/node-macaddress) from 0.2.8 to 0.2.9.
- [Release notes](https://github.com/scravy/node-macaddress/releases)
- [Commits](https://github.com/scravy/node-macaddress/compare/0.2.8...0.2.9)

Signed-off-by: dependabot[bot] <support@github.com>
2019-09-11 04:29:25 +02:00
dependabot[bot]
1952e046bb Bump debug from 2.6.8 to 2.6.9 in /app
Bumps [debug](https://github.com/visionmedia/debug) from 2.6.8 to 2.6.9.
- [Release notes](https://github.com/visionmedia/debug/releases)
- [Changelog](https://github.com/visionmedia/debug/blob/2.6.9/CHANGELOG.md)
- [Commits](https://github.com/visionmedia/debug/compare/2.6.8...2.6.9)

Signed-off-by: dependabot[bot] <support@github.com>
2019-09-11 04:25:22 +02:00
Zachary Riedlshah
970a98f60b fix: prettier fullscreen for macOS
fixes #5
2019-09-11 04:20:06 +02:00
James George
84bab83e88 switch to open (#3788) 2019-09-11 04:05:04 +02:00
dependabot[bot]
6d25ec612f Bump rgb2hex from 0.1.0 to 0.1.9 (#3801)
Bumps [rgb2hex](https://github.com/christian-bromann/rgb2hex) from 0.1.0 to 0.1.9.
- [Release notes](https://github.com/christian-bromann/rgb2hex/releases)
- [Commits](https://github.com/christian-bromann/rgb2hex/compare/v0.1.0...v0.1.9)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: null <49699333+dependabot[bot]@users.noreply.github.com>
2019-09-11 04:03:12 +02:00
Chamoda Pandithage
758e93c21e Add a way to fix macos compiler error to README.md (#3680) 2019-07-31 00:07:12 +02:00
J. Cameron McDonald
04a5e75c15 Split Vertically -> Split Right, Split Horizontally -> Split Down (#3559) 2019-07-31 00:03:33 +02:00
dependabot[bot]
9418dfd3aa Bump lodash-es from 4.17.5 to 4.17.15 (#3774)
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.5 to 4.17.15.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.5...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>
2019-07-30 18:38:17 +02:00
dependabot[bot]
77b91ca7fd Bump stringstream from 0.0.5 to 0.0.6 (#3776)
Bumps [stringstream](https://github.com/mhart/StringStream) from 0.0.5 to 0.0.6.
- [Release notes](https://github.com/mhart/StringStream/releases)
- [Commits](https://github.com/mhart/StringStream/compare/v0.0.5...v0.0.6)

Signed-off-by: dependabot[bot] <support@github.com>
2019-07-30 18:38:03 +02:00
dependabot[bot]
31aa130d23 Bump eslint from 4.7.2 to 4.18.2 (#3775)
Bumps [eslint](https://github.com/eslint/eslint) from 4.7.2 to 4.18.2.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v4.7.2...v4.18.2)

Signed-off-by: dependabot[bot] <support@github.com>
2019-07-30 18:37:05 +02:00
dependabot[bot]
9dbe623af6 Bump lodash.merge from 4.6.1 to 4.6.2 (#3777)
Bumps [lodash.merge](https://github.com/lodash/lodash) from 4.6.1 to 4.6.2.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2019-07-30 18:33:39 +02:00
dependabot[bot]
a748860ec9 Bump lodash from 4.17.5 to 4.17.15 (#3773)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.5 to 4.17.15.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.5...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>
2019-07-30 18:29:58 +02:00
dependabot[bot]
a4e32b7ddf Bump lodash from 4.17.5 to 4.17.13 in /app (#3772)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.5 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.5...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>
2019-07-30 18:29:39 +02:00
Piolin Victor
8845d0261b Fix drag and drop directories onto command line (#3690)
Fixes #3582
2019-07-30 16:02:14 +02:00
Eric Taylor
d885acb064 fix: load scoped plugins (#3672)
fixes #3288
2019-07-30 15:53:55 +02:00