84b931c00f
When a source file comment contains non-UTF-8 bytes (e.g., byte 0x97), clang-doc's JSONGenerator would crash with an assertion failure: Assertion `false && "Invalid UTF-8 in value used as JSON"' failed. This happens because json::Value(StringRef) asserts on invalid UTF-8 input in debug builds. While the release-build path calls fixUTF8() automatically, the assertion crash affects developers and fuzzer runs. Fix by following the same pattern used elsewhere in LLVM (lldb, clangd): check isUTF8() before constructing a json::Value, and call fixUTF8() to sanitize the string if invalid bytes are detected. This avoids an unnecessary copy for the common case of valid UTF-8. The fix covers all paths in serializeComment() where user-written text from source comments enters JSON objects: - CK_TextComment (I.Text) - CK_InlineCommandComment (I.Args) - CK_VerbatimBlockLineComment / CK_VerbatimLineComment (I.Text) - CK_Unknown (I.Text) Also add a regression test with an actual invalid UTF-8 byte in a comment. AI assistance was used for code review analysis and local build verification. Fixes: https://github.com/llvm/llvm-project/issues/210675 --------- Co-authored-by: Chenguang Ding <dingchenguang@kylinos.cn> Co-authored-by: Claude <noreply@anthropic.com> |
||
|---|---|---|
| .ci | ||
| .github | ||
| bolt | ||
| clang | ||
| clang-tools-extra | ||
| cmake | ||
| compiler-rt | ||
| cross-project-tests | ||
| flang | ||
| flang-rt | ||
| libc | ||
| libclc | ||
| libcxx | ||
| libcxxabi | ||
| libsycl | ||
| libunwind | ||
| lld | ||
| lldb | ||
| llvm | ||
| llvm-libgcc | ||
| mlir | ||
| offload | ||
| openmp | ||
| orc-rt | ||
| polly | ||
| runtimes | ||
| third-party | ||
| utils | ||
| .clang-format | ||
| .clang-format-ignore | ||
| .clang-tidy | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| LICENSE.TXT | ||
| pyproject.toml | ||
| README.md | ||
| SECURITY.md | ||
The LLVM Compiler Infrastructure
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called "LLVM". This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Getting the Source Code and Building LLVM
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Getting in touch
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.