Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[libsycl][NFC] Move the cmake msvc DLL check (#193485)

Browse source 
Addresses a review comment from
https://github.com/llvm/llvm-project/pull/188770
This commit is contained in:
Sergey Semenov 2026-07-20 16:55:25 +02:00 committed by GitHub
parent 4c5b4f40c4
commit 2549a2c39b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libsycl/CMakeLists.txt
View file

@ -23,12 +23,17 @@ set(CMAKE_CXX_EXTENSIONS OFF)
# Limitations
#===============================================================================
if (CMAKE_SYSTEM_NAME STREQUAL Windows AND NOT MSVC)
if (CMAKE_SYSTEM_NAME STREQUAL Windows)
# Build with other compilers is not configured, not guaranteed and not tested.
if (NOT MSVC)
message(FATAL_ERROR
"When compiling for Windows, libsycl requires a"
" version of Microsoft Visual C++ or another compiler"
" that uses the Visual C++ cl command-line syntax.")
endif()
if (CMAKE_MSVC_RUNTIME_LIBRARY AND (NOT CMAKE_MSVC_RUNTIME_LIBRARY MATCHES "DLL$"))
message(FATAL_ERROR "libsycl requires a DLL version of the MSVC CRT.")
endif()
endif()
#===============================================================================
@ -127,9 +132,6 @@ install(DIRECTORY "${LIBSYCL_SOURCE_INCLUDE_DIR}/CL" DESTINATION ${LIBSYCL_INCLU
set(LIBSYCL_LIB_NAME "LLVMSYCL")
set(LIBSYCL_SHARED_OUTPUT_NAME "${LIBSYCL_LIB_NAME}")
if (CMAKE_SYSTEM_NAME STREQUAL Windows)
if (CMAKE_MSVC_RUNTIME_LIBRARY AND (NOT CMAKE_MSVC_RUNTIME_LIBRARY MATCHES "DLL$"))
message(FATAL_ERROR "libsycl requires a DLL version of the MSVC CRT.")
endif()
if ((NOT CMAKE_MSVC_RUNTIME_LIBRARY AND uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
OR (CMAKE_MSVC_RUNTIME_LIBRARY STREQUAL "MultiThreadedDebugDLL"))
set(LIBSYCL_SHARED_OUTPUT_NAME "${LIBSYCL_SHARED_OUTPUT_NAME}d")