quine-global/webdriverio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(webdriverio): fix element chaining if element is not found (#14656)

Browse source
This commit is contained in:
Erwin Heitzman 2025-07-22 17:58:30 +02:00 committed by GitHub
parent 87f33dacfe
commit f6d1baa41f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
packages/webdriverio/src/utils/index.ts
View file

@ -306,7 +306,7 @@ export function transformClassicToBidiSelector (using: string, value: string): r
export async function findDeepElement(
this: WebdriverIO.Browser | WebdriverIO.Element,
selector: Selector
): Promise<ElementReference | Error> {
): Promise<ElementReference | undefined> {
const browser = getBrowserObject(this)
const shadowRootManager = getShadowRootManager(browser)
const contextManager = getContextManager(browser)
@ -349,7 +349,7 @@ export async function findDeepElement(
node as unknown as HTMLElement
)
return [isIn, node]
})).then((elems) => elems.filter(([isIn]) => isIn).map(([, elem]) => elem))
})).then((elems) => elems.filter(([isIn]) => isIn).map(([, elem]) => elem)) as ExtendedElementReference[]
return scopedNodes[0]
}, (err) => {
@ -359,11 +359,7 @@ export async function findDeepElement(
: browser.findElement(using, value)
})
if (!deepElementResult) {
return new Error(`Couldn't find element with selector "${selector}"`)
}
return deepElementResult as ElementReference
return deepElementResult
}
/**
@ -459,7 +455,9 @@ export async function findElement(
* - and we are not in an iframe (because it is currently not supported to locate nodes in an iframe via Bidi)
*/
if (this.isBidi && typeof selector === 'string' && !selector.startsWith(DEEP_SELECTOR) && !shadowRootManager.isWithinFrame()) {
return findDeepElement.call(this, selector)
const notFoundError = new Error(`Couldn't find element with selector "${selector}"`)
const elem = await findDeepElement.call(this, selector)
return getElementFromResponse(elem) ? elem : notFoundError
}
/**