quine-global/webdriverio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: do not attach prefs when debuggerAddress is specified (#14634)

Browse source
This commit is contained in:
uladhsi 2025-07-14 17:44:25 +02:00 committed by GitHub
parent 04f7c4e0ba
commit b4e3884ea7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 33 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/wdio-utils/src/node/startWebDriver.ts
View file

@ -15,7 +15,7 @@ import type { InstallOptions } from '@puppeteer/browsers'
import type { Capabilities } from '@wdio/types'
import { parseParams, setupPuppeteerBrowser, setupChromedriver, getCacheDir } from './utils.js'
import { parseParams, setupPuppeteerBrowser, setupChromedriver, getCacheDir, generateDefaultPrefs } from './utils.js'
import { isChrome, isFirefox, isEdge, isSafari, isAppiumCapability } from '../utils.js'
import { SUPPORTED_BROWSERNAMES } from '../constants.js'
@ -84,8 +84,10 @@ export async function startWebDriver (options: Capabilities.RemoteConfig) {
? { executablePath: chromedriverBinary }
: await setupChromedriver(cacheDir, browserVersion)
const prefs = generateDefaultPrefs(caps)
caps['goog:chromeOptions'] = deepmerge(
{ binary: chromeExecuteablePath, prefs: { 'profile.password_manager_leak_detection': false } },
{ binary: chromeExecuteablePath },
prefs,
caps['goog:chromeOptions'] || {}
)
chromedriverOptions.allowedOrigins = chromedriverOptions.allowedOrigins || ['*']

6
packages/wdio-utils/src/node/utils.ts
View file

@ -323,3 +323,9 @@ export function setupGeckodriver (cacheDir: string, driverVersion?: string) {
export function setupEdgedriver (cacheDir: string, driverVersion?: string) {
return downloadEdgedriver(driverVersion, cacheDir)
}
export function generateDefaultPrefs(caps: WebdriverIO.Capabilities) {
return caps['goog:chromeOptions']?.debuggerAddress
? {}
: { prefs: { 'profile.password_manager_leak_detection': false } }
}

23
packages/wdio-utils/tests/node/index.test.ts
View file

@ -226,6 +226,29 @@ describe('startWebDriver', () => {
)
})
it('should start driver with no prefs if debuggerAddress is set', async () => {
const options = {
capabilities: {
browserName: 'chrome',
'goog:chromeOptions': { debuggerAddress: 'localhost:9222' }
} as any
}
const res = await startWebDriver(options)
expect(Boolean(res?.stdout)).toBe(true)
expect(options).toEqual({
hostname: 'localhost',
port: 1234,
capabilities: {
browserName: 'chrome',
'goog:chromeOptions': {
// no prefs should be set in this case
binary: expect.any(String),
debuggerAddress: 'localhost:9222'
}
}
})
})
it('should start no driver or download chrome if binaries are defined', async () => {
const options = {
capabilities: {