port app/menus to ts

app/menus/menus/darwin.ts

@@ -1,8 +1,12 @@
 // This menu label is overrided by OSX to be the appName
 // The label is set to appName here so it matches actual behavior
-import {app} from 'electron';
+import {app, BrowserWindow, MenuItemConstructorOptions} from 'electron';
 
-export default (commandKeys, execCommand, showAbout) => {
+export default (
+  commandKeys: Record<string, string>,
+  execCommand: (command: string, focusedWindow?: BrowserWindow) => void,
+  showAbout: () => void
+): MenuItemConstructorOptions => {
   return {
     label: `${app.getName()}`,
     submenu: [
@@ -36,7 +40,7 @@ export default (commandKeys, execCommand, showAbout) => {
         role: 'hide'
       },
       {
-        role: 'hideothers'
+        role: 'hideOthers'
       },
       {
         role: 'unhide'

app/menus/menus/edit.ts

@@ -1,5 +1,10 @@
-export default (commandKeys, execCommand) => {
+import {BrowserWindow, MenuItemConstructorOptions} from 'electron';
-  const submenu = [
+
+export default (
+  commandKeys: Record<string, string>,
+  execCommand: (command: string, focusedWindow?: BrowserWindow) => void
+) => {
+  const submenu: MenuItemConstructorOptions[] = [
     {
       label: 'Undo',
       accelerator: commandKeys['editor:undo'],
@@ -23,7 +28,7 @@ export default (commandKeys, execCommand) => {
       command: 'editor:copy',
       accelerator: commandKeys['editor:copy'],
       registerAccelerator: true
-    },
+    } as any,
     {
       role: 'paste',
       accelerator: commandKeys['editor:paste']

app/menus/menus/help.ts

@@ -1,11 +1,11 @@
 import {release} from 'os';
-import {app, shell} from 'electron';
+import {app, shell, MenuItemConstructorOptions} from 'electron';
 import {getConfig, getPlugins} from '../../config';
 const {arch, env, platform, versions} = process;
 import {version} from '../../package.json';
 
-export default (commands, showAbout) => {
+export default (commands: Record<string, string>, showAbout: () => void): MenuItemConstructorOptions => {
-  const submenu = [
+  const submenu: MenuItemConstructorOptions[] = [
     {
       label: `${app.getName()} Website`,
       click() {

app/menus/menus/plugins.ts

@@ -1,4 +1,9 @@
-export default (commands, execCommand) => {
+import {BrowserWindow, MenuItemConstructorOptions} from 'electron';
+
+export default (
+  commands: Record<string, string>,
+  execCommand: (command: string, focusedWindow?: BrowserWindow) => void
+): MenuItemConstructorOptions => {
   return {
     label: 'Plugins',
     submenu: [

app/menus/menus/shell.ts

@@ -1,4 +1,9 @@
-export default (commandKeys, execCommand) => {
+import {BrowserWindow, MenuItemConstructorOptions} from 'electron';
+
+export default (
+  commandKeys: Record<string, string>,
+  execCommand: (command: string, focusedWindow?: BrowserWindow) => void
+): MenuItemConstructorOptions => {
   const isMac = process.platform === 'darwin';
 
   return {

app/menus/menus/view.ts

@@ -1,4 +1,9 @@
-export default (commandKeys, execCommand) => {
+import {BrowserWindow, MenuItemConstructorOptions} from 'electron';
+
+export default (
+  commandKeys: Record<string, string>,
+  execCommand: (command: string, focusedWindow?: BrowserWindow) => void
+): MenuItemConstructorOptions => {
   return {
     label: 'View',
     submenu: [

app/menus/menus/window.ts

@@ -1,4 +1,9 @@
-export default (commandKeys, execCommand) => {
+import {BrowserWindow, MenuItemConstructorOptions} from 'electron';
+
+export default (
+  commandKeys: Record<string, string>,
+  execCommand: (command: string, focusedWindow?: BrowserWindow) => void
+): MenuItemConstructorOptions => {
   // Generating tab:jump array
   const tabJump = [];
   for (let i = 1; i <= 9; i++) {