quine-global/hyper
1
0
Fork 0
mirror of https://github.com/quine-global/hyper.git synced 2026-01-15 21:28:40 -09:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Always notify watchers of plugin updates (#2508)

Browse source 
During plugin updates, each `plugin.onUnload` is invoked regardless of
whether the plugin changed. This commit ensures that each `plugin.onApp`
is invoked once all plugins have been updated. Fixes #2415.
This commit is contained in:
David Calhoun 2018-01-04 05:45:28 -06:00 committed by Leo Lamprecht
parent cb8b72a319
commit bbb1caefb4
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/plugins.js
View file

@ -87,6 +87,8 @@ function updatePlugins({force = false} = {}) {
cache.set('hyper.plugin-versions', pluginVersions); cache.set('hyper.plugin-versions', pluginVersions);
// notify watchers // notify watchers
watchers.forEach(fn => fn(err, {force}));
if (force || changed) { if (force || changed) {
if (changed) { if (changed) {
notify('Plugins Updated', 'Restart the app or hot-reload with "View" > "Reload" to enjoy the updates!'); notify('Plugins Updated', 'Restart the app or hot-reload with "View" > "Reload" to enjoy the updates!');
@ -94,7 +96,6 @@ function updatePlugins({force = false} = {}) {
notify('Plugins Updated', 'No changes!'); notify('Plugins Updated', 'No changes!');
} }
checkDeprecatedExtendKeymaps(); checkDeprecatedExtendKeymaps();
watchers.forEach(fn => fn(err, {force}));
} }
} }
}); });