Remove externals, show window

.github/workflows/nodejs.yml

@@ -13,9 +13,11 @@ jobs:
     runs-on: ${{matrix.os}}
     strategy:
       matrix:
-        os:
-          - macos-latest
-          - ubuntu-latest
+        include:
+          - os: macos-latest
+            name: macos
+          - os: ubuntu-latest
+            name: ubuntu
           #TODO re-enable these:
           #- windows-latest
       fail-fast: false

app/index.ts

@@ -141,7 +141,11 @@ app.on('ready', () =>
 
         const hwin = newWindow({width, height, x: startX, y: startY}, cfg, fn, profileName);
         windowSet.add(hwin);
-        void hwin.loadURL(url);
+        void hwin.loadURL(url)
+
+        hwin.once('ready-to-show', () => {
+          hwin.show();
+        });
 
         // the window can be closed by the browser process itself
         hwin.on('close', () => {

webpack.config.ts

@@ -100,32 +100,6 @@ const config: webpack.Configuration[] = [
       ]
     },
     externals: {
-      'color-convert': 'commonjs color-convert',
-      'color-string': 'commonjs color-string',
-      columnify: 'commonjs columnify',
-      lodash: 'commonjs lodash',
-      ms: 'commonjs ms',
-      'normalize-url': 'commonjs normalize-url',
-      'parse-url': 'commonjs parse-url',
-      'php-escape-shell': 'commonjs php-escape-shell',
-      plist: 'commonjs plist',
-      // 'react-dom': 'commonjs react-dom',
-      'redux-thunk': 'commonjs redux-thunk',
-      redux: 'commonjs redux',
-      reselect: 'commonjs reselect',
-      'seamless-immutable': 'commonjs seamless-immutable',
-      stylis: 'commonjs stylis',
-      '@xterm/addon-unicode11': 'commonjs @xterm/addon-unicode11',
-      args: 'commonjs args',
-      mousetrap: 'commonjs mousetrap',
-      open: 'commonjs open',
-      '@xterm/addon-fit': 'commonjs @xterm/addon-fit',
-      '@xterm/addon-image': 'commonjs @xterm/addon-image',
-      '@xterm/addon-search': 'commonjs @xterm/addon-search',
-      '@xterm/addon-web-links': 'commonjs @xterm/addon-web-links',
-      '@xterm/addon-webgl': 'commonjs @xterm/addon-webgl',
-      '@xterm/addon-canvas': 'commonjs @xterm/addon-canvas',
-      xterm: 'commonjs xterm'
     },
     plugins: [
       new webpack.IgnorePlugin({resourceRegExp: /.*\.js.map$/i}),