From ae70054e59c1d0ac21f93bffb3a7fa5c1432042a Mon Sep 17 00:00:00 2001
From: Labhansh Agrawal <labhansh.agrawal@gmail.com>
Date: Sun, 28 Mar 2021 22:37:04 +0530
Subject: [PATCH] Fix @typescript-eslint/no-unnecessary-type-assertion errors

---
 .eslintrc.json                  | 1 -
 app/config/import.ts            | 2 +-
 lib/actions/term-groups.ts      | 4 ++--
 lib/actions/ui.ts               | 2 +-
 lib/components/notification.tsx | 2 +-
 lib/utils/plugins.ts            | 2 +-
 6 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 03e9cd1e..44d8df5f 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -104,7 +104,6 @@
         "@typescript-eslint/ban-types": "off",
         "no-shadow": "off",
         "@typescript-eslint/no-shadow": ["error"],
-        "@typescript-eslint/no-unnecessary-type-assertion": "off",
         "@typescript-eslint/no-unsafe-assignment": "off",
         "@typescript-eslint/no-unsafe-call": "off",
         "@typescript-eslint/no-unsafe-member-access": "off",
diff --git a/app/config/import.ts b/app/config/import.ts
index d0a954ef..a38d18ec 100644
--- a/app/config/import.ts
+++ b/app/config/import.ts
@@ -126,7 +126,7 @@ const _importConf = () => {
 export const _import = () => {
   const imported = _importConf();
   defaultConfig = imported.defaultCfg;
-  const result = _init(imported!);
+  const result = _init(imported);
   return result;
 };
 
diff --git a/lib/actions/term-groups.ts b/lib/actions/term-groups.ts
index 57a04e23..154d07a4 100644
--- a/lib/actions/term-groups.ts
+++ b/lib/actions/term-groups.ts
@@ -101,7 +101,7 @@ const findNextSessionUid = (state: Immutable<ITermState>, group: Immutable<ITerm
 
   const {children} = state.termGroups[group.parentUid!];
   const nextUid = findPrevious(children.asMutable(), group.uid);
-  return findFirstSession(state, state.termGroups[nextUid!]);
+  return findFirstSession(state, state.termGroups[nextUid]);
 };
 
 export function ptyExitTermGroup(sessionUid: string) {
@@ -168,7 +168,7 @@ export function exitActiveTermGroup() {
       effect() {
         const {sessions, termGroups} = getState();
         const {uid} = findBySession(termGroups, sessions.activeUid!)!;
-        dispatch(userExitTermGroup(uid!));
+        dispatch(userExitTermGroup(uid));
       }
     });
   };
diff --git a/lib/actions/ui.ts b/lib/actions/ui.ts
index 02e80366..fb83e676 100644
--- a/lib/actions/ui.ts
+++ b/lib/actions/ui.ts
@@ -144,7 +144,7 @@ function moveToNeighborPane(type: typeof UI_MOVE_NEXT_PANE | typeof UI_MOVE_PREV
         if (childGroups.length === 1) {
           console.log('ignoring move for single group');
         } else {
-          const index = getNeighborIndex(childGroups, uid!, type);
+          const index = getNeighborIndex(childGroups, uid, type);
           const {sessionUid} = termGroups.termGroups[childGroups[index]];
           dispatch(setActiveSession(sessionUid!));
         }
diff --git a/lib/components/notification.tsx b/lib/components/notification.tsx
index 03337cfd..12e33eb1 100644
--- a/lib/components/notification.tsx
+++ b/lib/components/notification.tsx
@@ -50,7 +50,7 @@ export default class Notification extends React.PureComponent<NotificationProps,
   setDismissTimer() {
     this.dismissTimer = setTimeout(() => {
       this.handleDismiss();
-    }, this.props.dismissAfter!);
+    }, this.props.dismissAfter);
   }
 
   resetDismissTimer() {
diff --git a/lib/utils/plugins.ts b/lib/utils/plugins.ts
index 5a574ae1..0c652539 100644
--- a/lib/utils/plugins.ts
+++ b/lib/utils/plugins.ts
@@ -212,7 +212,7 @@ const getPluginName = (path: string) => pathModule.basename(path);
 const getPluginVersion = (path: string): string | null => {
   let version = null;
   try {
-    version = (window.require(pathModule.resolve(path, 'package.json')) as any).version as string;
+    version = window.require(pathModule.resolve(path, 'package.json')).version as string;
   } catch (err) {
     console.warn(`No package.json found in ${path}`);
   }