quine-global/hyper
1
0
Fork 0
mirror of https://github.com/quine-global/hyper.git synced 2026-01-15 21:28:40 -09:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

🐛 Handle electron default env (#1764)

Browse source
This commit is contained in:
Albin Ekblom 2017-04-28 22:57:17 +02:00 committed by Guillermo Rauch
parent 9eb31ea55c
commit aa7e79a039
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/session.js
View file

@ -30,6 +30,13 @@ module.exports = class Session extends EventEmitter {
TERM_PROGRAM_VERSION: version TERM_PROGRAM_VERSION: version
}, envFromConfig); }, envFromConfig);
// Electron has a default value for process.env.GOOGLE_API_KEY
// We don't want to leak this to the shell
// See https://github.com/zeit/hyper/issues/696
if (baseEnv.GOOGLE_API_KEY && process.env.GOOGLE_API_KEY === baseEnv.GOOGLE_API_KEY) {
delete baseEnv.GOOGLE_API_KEY;
}
const decoder = new StringDecoder('utf8'); const decoder = new StringDecoder('utf8');
const defaultShellArgs = ['--login']; const defaultShellArgs = ['--login'];