From a4bfd0ae1eba059d6fb2103ed4eefd83c03753fb Mon Sep 17 00:00:00 2001 From: Guillermo Rauch Date: Fri, 1 Jul 2016 16:50:28 -0700 Subject: [PATCH] add `default-shell` and missing `--login` option for interactive mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit seriously @sindresorhus every single package I need… --- package.json | 3 ++- session.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 87ca6937..a35109bc 100644 --- a/package.json +++ b/package.json @@ -5,9 +5,10 @@ "description": "", "dependencies": { "child_pty": "3.0.1", + "default-shell": "1.0.1", "electron-is-dev": "0.1.1", - "electron-prebuilt": "1.2.5", "electron-packager": "7.1.0", + "electron-prebuilt": "1.2.5", "uid2": "0.0.3" }, "devDependencies": { diff --git a/session.js b/session.js index 414feb6c..bdfb8016 100644 --- a/session.js +++ b/session.js @@ -1,6 +1,7 @@ const { EventEmitter } = require('events'); const { spawn } = require('child_pty'); const { exec } = require('child_process'); +const defaultShell = require('default-shell'); const TITLE_POLL_INTERVAL = 1000; @@ -8,7 +9,7 @@ module.exports = class Session extends EventEmitter { constructor ({ rows, cols }) { super(); - this.pty = spawn('bash', [], { + this.pty = spawn(defaultShell, ['--login'], { cols, rows, cwd: process.env.HOME,