quine-global/hyper
1
0
Fork 0
mirror of https://github.com/quine-global/hyper.git synced 2026-01-12 20:18:41 -09:00
Code Issues Projects Releases Packages Wiki Activity Actions

Focus term if needed when restoring (#2658)

Browse source 
* Focus term if needed when restoring

* Fix Tab component warnings
This commit is contained in:
CHaBou 2018-02-03 17:00:30 +01:00 committed by GitHub
parent 4d8d56bfc5
commit 887fb5ac1a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/components/tab.js
View file

@ -14,10 +14,6 @@ export default class Tab extends PureComponent {
}; };
} }
shouldComponentUpdate() {
return true;
}
handleHover() { handleHover() {
this.setState({ this.setState({
hovered: true hovered: true

10
lib/components/term.js
View file

@ -80,6 +80,9 @@ export default class Term extends PureComponent {
//We need to set options again after reattaching an existing term //We need to set options again after reattaching an existing term
Object.keys(this.termOptions).forEach(option => this.term.setOption(option, this.termOptions[option])); Object.keys(this.termOptions).forEach(option => this.term.setOption(option, this.termOptions[option]));
} }
if (this.props.isTermActive) {
this.term.focus();
}
this.onOpen(this.termOptions); this.onOpen(this.termOptions);
@ -88,12 +91,7 @@ export default class Term extends PureComponent {
} }
if (props.onActive) { if (props.onActive) {
this.term.on('focus', () => { this.term.on('focus', props.onActive);
// xterm@2 emits this event 2 times. Will be fixed in xterm@3.
if (!this.props.isTermActive) {
props.onActive();
}
});
} }
if (props.onData) { if (props.onData) {