Re-enable Windows (#129)

.github/workflows/nodejs.yml

@@ -18,8 +18,8 @@ jobs:
             name: macos
           - os: ubuntu-latest
             name: ubuntu
-          #TODO re-enable these:
-          #- windows-latest
+          - os: windows-latest
+            name: win
       fail-fast: false
     steps:
       - name: Checkout

app/index.ts

@@ -141,7 +141,7 @@ app.on('ready', () =>
 
         const hwin = newWindow({width, height, x: startX, y: startY}, cfg, fn, profileName);
         windowSet.add(hwin);
-        void hwin.loadURL(url)
+        void hwin.loadURL(url);
 
         hwin.once('ready-to-show', () => {
           hwin.show();

bin/mk-snapshot.js

@@ -50,7 +50,7 @@ async function main() {
 
   console.log(`Generating startup blob in "${outputBlobPath}"`);
   const res = childProcess.execFileSync(
-    path.resolve(__dirname, '..', 'node_modules', 'electron-mksnapshot', 'bin', 'mksnapshot' + (process.platform === 'win32' ? '.cmd' : '')),
+    path.resolve(__dirname, '..', 'node_modules', 'electron-mksnapshot', 'bin', 'mksnapshot' + (process.platform === 'win32' ? '.exe' : '')),
     [
       '--startup-src=' + snapshotScriptPath,
       '--startup-blob=' + startupBlobPath,

webpack.config.ts

@@ -99,8 +99,7 @@ const config: webpack.Configuration[] = [
         }
       ]
     },
-    externals: {
-    },
+    externals: {},
     plugins: [
       new webpack.IgnorePlugin({resourceRegExp: /.*\.js.map$/i}),