Re-enable Windows (#129)
Some checks are pending
CodeQL / Analyze (push) Waiting to run

This commit is contained in:
Philip Peterson 2025-04-24 21:37:56 -07:00 committed by GitHub
parent ee9ebb0c12
commit 6340e0001c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 5 additions and 6 deletions

View file

@ -18,8 +18,8 @@ jobs:
name: macos name: macos
- os: ubuntu-latest - os: ubuntu-latest
name: ubuntu name: ubuntu
#TODO re-enable these: - os: windows-latest
#- windows-latest name: win
fail-fast: false fail-fast: false
steps: steps:
- name: Checkout - name: Checkout

View file

@ -141,7 +141,7 @@ app.on('ready', () =>
const hwin = newWindow({width, height, x: startX, y: startY}, cfg, fn, profileName); const hwin = newWindow({width, height, x: startX, y: startY}, cfg, fn, profileName);
windowSet.add(hwin); windowSet.add(hwin);
void hwin.loadURL(url) void hwin.loadURL(url);
hwin.once('ready-to-show', () => { hwin.once('ready-to-show', () => {
hwin.show(); hwin.show();

2
bin/mk-snapshot.js vendored
View file

@ -50,7 +50,7 @@ async function main() {
console.log(`Generating startup blob in "${outputBlobPath}"`); console.log(`Generating startup blob in "${outputBlobPath}"`);
const res = childProcess.execFileSync( const res = childProcess.execFileSync(
path.resolve(__dirname, '..', 'node_modules', 'electron-mksnapshot', 'bin', 'mksnapshot' + (process.platform === 'win32' ? '.cmd' : '')), path.resolve(__dirname, '..', 'node_modules', 'electron-mksnapshot', 'bin', 'mksnapshot' + (process.platform === 'win32' ? '.exe' : '')),
[ [
'--startup-src=' + snapshotScriptPath, '--startup-src=' + snapshotScriptPath,
'--startup-blob=' + startupBlobPath, '--startup-blob=' + startupBlobPath,

View file

@ -99,8 +99,7 @@ const config: webpack.Configuration[] = [
} }
] ]
}, },
externals: { externals: {},
},
plugins: [ plugins: [
new webpack.IgnorePlugin({resourceRegExp: /.*\.js.map$/i}), new webpack.IgnorePlugin({resourceRegExp: /.*\.js.map$/i}),