quine-global/hyper
1
0
Fork 0
mirror of https://github.com/quine-global/hyper.git synced 2026-01-16 21:58:39 -09:00
Code Issues Projects Releases Packages Wiki Activity Actions

Comply to XO's no-warning-comments rule

Browse source
This commit is contained in:
Leo Lamprecht 2016-10-25 15:04:37 +02:00
parent 8f28573fc0
commit 630f0f4504
No known key found for this signature in database
GPG key ID: EF804E3FF4BBA8AB
6 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/actions/sessions.js
View file

@ -108,7 +108,7 @@ export function setActiveSession(uid) {
type: SESSION_SET_ACTIVE, type: SESSION_SET_ACTIVE,
uid, uid,
effect() { effect() {
// TODO: this goes away when we are able to poll // This goes away when we are able to poll
// for the title ourseleves, instead of relying // for the title ourseleves, instead of relying
// on Session and focus/blur to subscribe // on Session and focus/blur to subscribe
if (prevUid) { if (prevUid) {

2
lib/actions/ui.js
View file

@ -207,7 +207,7 @@ export function showPreferences() {
type: UI_SHOW_PREFERENCES, type: UI_SHOW_PREFERENCES,
effect() { effect() {
dispatch(requestSession()); dispatch(requestSession());
// TODO: replace this hack with an async action // Replace this hack with an async action
rpc.once('session add', ({uid}) => { rpc.once('session add', ({uid}) => {
rpc.once('session data', () => { rpc.once('session data', () => {
dispatch(sendSessionData( dispatch(sendSessionData(

2
lib/components/term-group.js
View file

@ -74,7 +74,7 @@ class TermGroup_ extends Component {
onURLAbort: this.bind(this.props.onURLAbort, null, uid) onURLAbort: this.bind(this.props.onURLAbort, null, uid)
}); });
// TODO: This will create a new ref_ function for every render, // This will create a new ref_ function for every render,
// which is inefficient. Should maybe do something similar // which is inefficient. Should maybe do something similar
// to this.bind. // to this.bind.
return (<Term return (<Term

2
lib/components/term.js
View file

@ -114,7 +114,7 @@ export default class Term extends Component {
} }
handleFocus() { handleFocus() {
// TODO: This will in turn result in `this.focus()` being // This will in turn result in `this.focus()` being
// called, which is unecessary. // called, which is unecessary.
// Should investigate if it matters. // Should investigate if it matters.
this.props.onActive(); this.props.onActive();

2
lib/reducers/ui.js
View file

@ -23,7 +23,7 @@ import {values} from '../utils/object';
const allowedCursorShapes = new Set(['BEAM', 'BLOCK', 'UNDERLINE']); const allowedCursorShapes = new Set(['BEAM', 'BLOCK', 'UNDERLINE']);
const allowedBells = new Set(['SOUND', false]); const allowedBells = new Set(['SOUND', false]);
// TODO: populate `config-default.js` from this :) // Populate `config-default.js` from this :)
const initial = Immutable({ const initial = Immutable({
cols: null, cols: null,
rows: null, rows: null,

1
package.json
View file

@ -21,7 +21,6 @@
], ],
"rules": { "rules": {
"new-cap": 0, "new-cap": 0,
"no-warning-comments": 0,
"complexity": 0, "complexity": 0,
"react/prop-types": 0, "react/prop-types": 0,
"react/jsx-no-bind": 0 "react/jsx-no-bind": 0