From 5224bc5c419b1b0c0a8c5320269892fda435f348 Mon Sep 17 00:00:00 2001 From: Bet4 <0xbet4@gmail.com> Date: Fri, 23 Apr 2021 17:15:14 +0800 Subject: [PATCH] Fix logic in saveAsBackup --- app/config/import.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/app/config/import.ts b/app/config/import.ts index 88a056f8..613f57ff 100644 --- a/app/config/import.ts +++ b/app/config/import.ts @@ -23,17 +23,12 @@ const _write = (path: string, data: string) => { const saveAsBackup = (src: string) => { let attempt = 1; while (attempt < 100) { - try { - const backupPath = `${src}.backup${attempt === 1 ? '' : attempt}`; + const backupPath = `${src}.backup${attempt === 1 ? '' : attempt}`; + if (!existsSync(backupPath)) { moveSync(src, backupPath); return backupPath; - } catch (e) { - if (e.code === 'EEXIST') { - attempt++; - } else { - throw e; - } } + attempt++; } throw new Error('Failed to create backup for config file. Too many backups'); };