quine-global/hyper
1
0
Fork 0
mirror of https://github.com/quine-global/hyper.git synced 2026-01-13 04:28:41 -09:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed some redundant code (#5577)

Browse source 
* Fixed some redundant code, index.ts (Check line 210)
Also prefixed 'event' in line 226 and 232 with _ since they are unused

* Fixed a wrongful autoimport

* Removed a finished FIXME

* Name the function and fix typo

Co-authored-by: Labhansh Agrawal <labhansh.agrawal@gmail.com>
This commit is contained in:
T•Ø•R•Ü•S 2021-05-13 01:04:16 +04:00 committed by GitHub
parent e9841db526
commit 31f357a0ba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
app/index.ts
View file

@ -206,11 +206,12 @@ app.on('ready', () =>
}) })
); );
app.on('open-file', (event, path) => { /**
* Get last focused BrowserWindow or create new if none and callback
* @param callback Function to call with the BrowserWindow
*/
function GetWindow(callback: (win: BrowserWindow) => void) {
const lastWindow = app.getLastFocusedWindow(); const lastWindow = app.getLastFocusedWindow();
const callback = (win: BrowserWindow) => {
win.rpc.emit('open file', {path});
};
if (lastWindow) { if (lastWindow) {
callback(lastWindow); callback(lastWindow);
} else if (!lastWindow && {}.hasOwnProperty.call(app, 'createWindow')) { } else if (!lastWindow && {}.hasOwnProperty.call(app, 'createWindow')) {
@ -220,20 +221,16 @@ app.on('open-file', (event, path) => {
// sets his callback to an app.windowCallback property. // sets his callback to an app.windowCallback property.
app.windowCallback = callback; app.windowCallback = callback;
} }
}
app.on('open-file', (_event, path) => {
GetWindow((win: BrowserWindow) => {
win.rpc.emit('open file', {path});
});
}); });
app.on('open-url', (event, sshUrl) => { app.on('open-url', (_event, sshUrl) => {
const lastWindow = app.getLastFocusedWindow(); GetWindow((win: BrowserWindow) => {
const callback = (win: BrowserWindow) => {
win.rpc.emit('open ssh', sshUrl); win.rpc.emit('open ssh', sshUrl);
}; });
if (lastWindow) {
callback(lastWindow);
} else if (!lastWindow && {}.hasOwnProperty.call(app, 'createWindow')) {
app.createWindow(callback);
} else {
// If createWindow doesn't exist yet ('ready' event was not fired),
// sets his callback to an app.windowCallback property.
app.windowCallback = callback;
}
}); });