quine-global/hyper
1
0
Fork 0
mirror of https://github.com/quine-global/hyper.git synced 2026-01-12 20:18:41 -09:00
Code Issues Projects Releases Packages Wiki Activity Actions

filter out undefined keys from createSession extraOptions

Browse source
This commit is contained in:
Labhansh Agrawal 2020-03-04 18:37:52 +05:30 committed by Benjamin Staneck
parent 150f462ac9
commit 1163173ade
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/ui/window.ts
View file

@ -112,6 +112,10 @@ export function newWindow(
function createSession(extraOptions: any = {}) { function createSession(extraOptions: any = {}) {
const uid = uuidv4(); const uid = uuidv4();
const extraOptionsFiltered: any = {};
Object.keys(extraOptions).forEach(key => {
if (extraOptions[key] !== undefined) extraOptionsFiltered[key] = extraOptions[key];
});
// remove the rows and cols, the wrong value of them will break layout when init create // remove the rows and cols, the wrong value of them will break layout when init create
const defaultOptions = Object.assign( const defaultOptions = Object.assign(
@ -121,7 +125,7 @@ export function newWindow(
shell: cfg.shell, shell: cfg.shell,
shellArgs: cfg.shellArgs && Array.from(cfg.shellArgs) shellArgs: cfg.shellArgs && Array.from(cfg.shellArgs)
}, },
extraOptions, extraOptionsFiltered,
{uid} {uid}
); );
const options = decorateSessionOptions(defaultOptions); const options = decorateSessionOptions(defaultOptions);