From 04a5e75c1516b9855aa306d5577ceb65b2a71878 Mon Sep 17 00:00:00 2001 From: "J. Cameron McDonald" Date: Tue, 30 Jul 2019 17:03:33 -0500 Subject: [PATCH] Split Vertically -> Split Right, Split Horizontally -> Split Down (#3559) --- app/commands.js | 4 ++-- app/keymaps/darwin.json | 4 ++-- app/keymaps/linux.json | 4 ++-- app/keymaps/win32.json | 4 ++-- app/menus/menus/shell.js | 12 ++++++------ 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/app/commands.js b/app/commands.js index 2cecfe93..19632cd4 100644 --- a/app/commands.js +++ b/app/commands.js @@ -15,10 +15,10 @@ const commands = { setTimeout(app.createWindow, 0); } }, - 'pane:splitVertical': focusedWindow => { + 'pane:splitRight': focusedWindow => { focusedWindow && focusedWindow.rpc.emit('split request vertical'); }, - 'pane:splitHorizontal': focusedWindow => { + 'pane:splitDown': focusedWindow => { focusedWindow && focusedWindow.rpc.emit('split request horizontal'); }, 'pane:close': focusedWindow => { diff --git a/app/keymaps/darwin.json b/app/keymaps/darwin.json index ab904116..908e71ab 100644 --- a/app/keymaps/darwin.json +++ b/app/keymaps/darwin.json @@ -30,8 +30,8 @@ "tab:jump:prefix": "command", "pane:next": "command+]", "pane:prev": "command+[", - "pane:splitVertical": "command+d", - "pane:splitHorizontal": "command+shift+d", + "pane:splitRight": "command+d", + "pane:splitDown": "command+shift+d", "pane:close": "command+w", "editor:undo": "command+z", "editor:redo": "command+y", diff --git a/app/keymaps/linux.json b/app/keymaps/linux.json index 9067b4fe..1c9ff68d 100644 --- a/app/keymaps/linux.json +++ b/app/keymaps/linux.json @@ -27,8 +27,8 @@ "tab:jump:prefix": "ctrl", "pane:next": "ctrl+pageup", "pane:prev": "ctrl+pagedown", - "pane:splitVertical": "ctrl+shift+d", - "pane:splitHorizontal": "ctrl+shift+e", + "pane:splitRight": "ctrl+shift+d", + "pane:splitDown": "ctrl+shift+e", "pane:close": "ctrl+shift+w", "editor:undo": "ctrl+shift+z", "editor:redo": "ctrl+shift+y", diff --git a/app/keymaps/win32.json b/app/keymaps/win32.json index 08f78e4a..ce80196f 100644 --- a/app/keymaps/win32.json +++ b/app/keymaps/win32.json @@ -31,8 +31,8 @@ "tab:jump:prefix": "ctrl", "pane:next": "ctrl+pageup", "pane:prev": "ctrl+pagedown", - "pane:splitVertical": "ctrl+shift+d", - "pane:splitHorizontal": "ctrl+shift+e", + "pane:splitRight": "ctrl+shift+d", + "pane:splitDown": "ctrl+shift+e", "pane:close": "ctrl+shift+w", "editor:undo": "ctrl+shift+z", "editor:redo": "ctrl+shift+y", diff --git a/app/menus/menus/shell.js b/app/menus/menus/shell.js index ba6224aa..c02af006 100644 --- a/app/menus/menus/shell.js +++ b/app/menus/menus/shell.js @@ -22,17 +22,17 @@ module.exports = (commandKeys, execCommand) => { type: 'separator' }, { - label: 'Split Horizontally', - accelerator: commandKeys['pane:splitHorizontal'], + label: 'Split Down', + accelerator: commandKeys['pane:splitDown'], click(item, focusedWindow) { - execCommand('pane:splitHorizontal', focusedWindow); + execCommand('pane:splitDown', focusedWindow); } }, { - label: 'Split Vertically', - accelerator: commandKeys['pane:splitVertical'], + label: 'Split Right', + accelerator: commandKeys['pane:splitRight'], click(item, focusedWindow) { - execCommand('pane:splitVertical', focusedWindow); + execCommand('pane:splitRight', focusedWindow); } }, {