quine-global/hyper
1
0
Fork 0
mirror of https://github.com/quine-global/hyper.git synced 2026-01-12 20:18:41 -09:00
Code Issues Projects Releases Packages Wiki Activity Actions

add TODO comments for the new Electron async APIs that replace the remote module

Browse source
This commit is contained in:
Benjamin Staneck 2019-10-25 14:34:52 +02:00
parent b8a1ffd6b0
commit 03ff483bea
4 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/command-registry.js
View file

@ -1,4 +1,5 @@
import {remote} from 'electron'; import {remote} from 'electron';
// TODO: Should be updates to new async API https://medium.com/@nornagon/electrons-remote-module-considered-harmful-70d69500f31
const {getDecoratedKeymaps} = remote.require('./plugins'); const {getDecoratedKeymaps} = remote.require('./plugins');

2
lib/reducers/ui.ts
View file

@ -1,4 +1,6 @@
import {remote} from 'electron'; import {remote} from 'electron';
// TODO: Should be updates to new async API https://medium.com/@nornagon/electrons-remote-module-considered-harmful-70d69500f31
import Immutable, {Immutable as ImmutableType} from 'seamless-immutable'; import Immutable, {Immutable as ImmutableType} from 'seamless-immutable';
import {decorateUIReducer} from '../utils/plugins'; import {decorateUIReducer} from '../utils/plugins';
import {CONFIG_LOAD, CONFIG_RELOAD} from '../constants/config'; import {CONFIG_LOAD, CONFIG_RELOAD} from '../constants/config';

1
lib/utils/config.ts
View file

@ -1,4 +1,5 @@
import {ipcRenderer, remote} from 'electron'; import {ipcRenderer, remote} from 'electron';
// TODO: Should be updates to new async API https://medium.com/@nornagon/electrons-remote-module-considered-harmful-70d69500f31
const plugins = remote.require('./plugins') as typeof import('../../app/plugins'); const plugins = remote.require('./plugins') as typeof import('../../app/plugins');

2
lib/utils/plugins.ts
View file

@ -1,4 +1,6 @@
import {remote} from 'electron'; import {remote} from 'electron';
// TODO: Should be updates to new async API https://medium.com/@nornagon/electrons-remote-module-considered-harmful-70d69500f31
import {connect as reduxConnect} from 'react-redux'; import {connect as reduxConnect} from 'react-redux';
import {basename} from 'path'; import {basename} from 'path';