From 54bdc9ba5d22e8aaa724525b07931563d767ad9d Mon Sep 17 00:00:00 2001 From: Labhansh Agrawal Date: Mon, 19 Jul 2021 13:44:46 +0530 Subject: [PATCH 1/2] Use ubuntu 18 on github actions --- .github/workflows/nodejs.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 40901325..ddf4bf18 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -14,7 +14,10 @@ jobs: strategy: matrix: node-version: [14.x] - os: [macos-11.0, ubuntu-latest, windows-latest] + os: + - macos-11.0 + - ubuntu-18.04 + - windows-latest fail-fast: false steps: - name: Checkout From 1e64e72797f2fa9984dc29c538dbe1e6ae675f9b Mon Sep 17 00:00:00 2001 From: Labhansh Agrawal Date: Mon, 19 Jul 2021 13:45:35 +0530 Subject: [PATCH 2/2] Disable ligatures when using webgl renderer --- lib/components/term.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/components/term.tsx b/lib/components/term.tsx index b80f9d0f..54adb89a 100644 --- a/lib/components/term.tsx +++ b/lib/components/term.tsx @@ -176,7 +176,7 @@ export default class Term extends React.PureComponent { if (useWebGL) { this.term.loadAddon(new WebglAddon()); } - if (props.disableLigatures !== true) { + if (props.disableLigatures !== true && !useWebGL) { this.term.loadAddon(new LigaturesAddon()); } this.term.loadAddon(new Unicode11Addon());