Fixes several user-facing and non-user-facing typos.
Found via:
`codespell -S "*.actions,*.appdata.xml,*.desktop,*.json,*.kksrc,*.metainfo.xml,*.notifyrc,*.po,./po,*.xml" -L claus,doubleclick,filetest,flate,mis,nam,previousy,propt,substract,virtualy`
The scroll bar visibility can cause a binding loop as it becoming
visible can change the word wrap of the contents, which may causes the
size to increase, which triggers re-evaluation of the visibility. This
is jsut a temporary problem, as the size can't shrink due to the
scrollbar becoming visible, and there's only one vertical scrollbar.
Instead, use a delayed binding to give it some extra time. This is
similar to how this was handled in the notes applet.
Widget Explorer contains a lot of information about widgets and plenty
of buttons, but screen reader use is rather inconsistent - much of that
is not read out, including the central aspects of the explorer: widget
names and descriptions.
This change makes the components from the visual interface accessible
to screen readers. Along the way, the text for uninstalling widgets was
adjusted a bit to make it clearer and more consistent, using "uninstall"
thoughout and leaving "remove" for the action that removes active
widgets from panels/desktop without uninstalling them.
Now everything in the header, main content view, and footer all use the
same consistent largeSpacing margins on all sides. Everything aligns
vertically even if you draw lines on a screenshot, and it looks amazing.
Part of https://invent.kde.org/teams/vdg/issues/-/issues/74.
Make them larger and consistent on the left, right, and bottom, which
looks better. And reduce them on top which centers the header text in
the space and makes the buttons respect Fitts' Law.
Otherwise, other ways of closing the sidebar (e.g. pressing the screenshot
button) will also pop back to the panel settings.
"1" is a placeholder for the Panel type, since it's currently not exposed to QML. That will be changed before this MR is merged.
BUG:493048
`FIXED-IN: 6.2.0`
Widget explorer has a button that confirms uninstalling widgets. This
button uses title case as recommended by the HIG, but does so
incorrectly; it capitalizes the word "of" but short prepositions of less
than four characters are supposed to be lower case in APA style (and
most other style guides).
This change makes this label use correct title case and adds translation
context.
BUG: 492790
FIXED-IN: 6.3
Due to https://bugreports.qt.io/browse/QTBUG-127709, zero-speed
animations cause the remove and addDisplaced transitions to malfunction:
items end up overlapping.
Work around it for now by manually disabling those when the animation
speed is zero.
BUG: 483962
FIXED-IN: 6.1.5
According to the HIG, there's no need to repeat the subject since the subject gets inherited automatically from the row it's on.
| Before | After |
|--------|-------|
| {width=529 height=298} | {width=524 height=295} |
BUG: 489864
Since the Widget Explorer only closes when it loses focus, but
there's an exception during a drag and drop, it might get stuck
open. Immediately reclaiming focus will make sure it closes.
Example to test with:
- Right click on a panel, click "add widgets"
- open panel edit mode
- sidebar closes!
But:
- Right click on a panel, click "add widgets"
- drag and drop a widget to the panel
- open panel edit mode
- sidebar does not close :-(
With this MR it closes.
BUG: 488571
FIXED-IN: 6.1.1
besides the auto delete on expire, add a button in the
widget explorer footer to confirm the uninstall and do it
immediately
Porting to this component makes the visual styling consistent and lets
us change it in the future--if need be--from only one place. Some things
that were already using it did not specify enough conditions to have it
cycle through all of its various states, and that's been corrected here
too.
Part of https://invent.kde.org/plasma/plasma-workspace/-/issues/97.
There's already a timer for setting the model, and that's the thing that
we want to wait for anyway before showing the placeholder message. So
just bind to the running state of that timer, rather than a second
unnecessary one.
- All controls are moved to a header (more in line with other applets)
- Sidebar is wider to accomodate the rearranged layout
- Delete and running count are only shown on hover (more in line with the presentation used in KCMs)
This reverts commit f17eae91f6.
It was committed without adequate discussion and there were unresolved
discussions. Furthermore, no code review was done, and as a result it
shipped with visual regressions.
We will re-discuss and commit a fixed version if appropriate.
Summary:
After D28144, some animations are now too long because they were inappropriately
multiplying a duration value. That's no longer necessary, so let's remove the
multiplication.
Depends on D28144
Test Plan: Various things that were a bit too slow before feel just right now
Reviewers: #vdg, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28239
Summary:
`PlasmaExtras.Title` is literally identical to a level 1 Heading. Let's port to that
so we have less code to maintain and fewer things to change the next time we want to
adjust the look of titles
Test Plan: No visual changes
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27348
