quine-global-labs/mirror-kde-plasma-desktop
1
0
Fork 0
mirror of https://invent.kde.org/plasma/plasma-desktop.git synced 2026-11-03 22:59:45 -09:00
Code Issues Projects Releases Packages Wiki Activity

applets/kicker: don't do things with globalFavorites.favorites

Browse source 
Kicker writes its config's favoriteApps value to
globalFavorites.favorites if it is changed, and writes the new value to
the config on globalFavorites.favoritesChanged. This does nothing:
globalFavorites is a KAStatsFavoritesModel and only has a favorites
property for backward compatibility reasons; reading or writing it does
nothing except print a warning that this is unsupported, and
favoritesChanged is never emitted in this model, The only time that this
code every does anything is if the user somehow manages to change the
config value (and nothing changes it, so maybe with a Plasma script?).
And the only thing it does then is print a warning, so still not useful.

Lets' just remove it. (systemFavorites is a SimpleFavoritesModel, and
the property actually does something here).
This commit is contained in:
Christoph Wolk 2026-06-29 13:49:04 +02:00
parent 2b0ce5307f
commit f89d033f72
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
applets/kicker/main.qml
View file

@ -128,14 +128,6 @@ PlasmoidItem {
}
}
Connections {
target: kicker.globalFavorites
function onFavoritesChanged() {
Plasmoid.configuration.favoriteApps = kicker.globalFavorites.favorites;
}
}
Connections {
target: kicker.systemFavorites
@ -147,10 +139,6 @@ PlasmoidItem {
Connections {
target: Plasmoid.configuration
function onFavoriteAppsChanged() {
kicker.globalFavorites.favorites = Plasmoid.configuration.favoriteApps;
}
function onFavoriteSystemActionsChanged() {
kicker.systemFavorites.favorites = Plasmoid.configuration.favoriteSystemActions;
}