quine-global-labs/mirror-kde-plasma-desktop
1
0
Fork 0
mirror of https://invent.kde.org/plasma/plasma-desktop.git synced 2026-11-03 22:59:45 -09:00
Code Issues Projects Releases Packages Wiki Activity

Call KRunner KRunner

Browse source 
Summary:
Plasma uses inconsistent terminology to refer to KRunner, calling it "Run Command" in
Kicker/Kickoff/etc, but "Plasma Search" in System Settings. For reasons explained in
{T10966} neither term is ideal, and the inconsistency is bad too.

This patch unifies on "Show KRunner" for the action and "KRunner" for the KCM name,
transforming it into a recognizable brand name like Apple's Spotlight.

This patch also makes the icons consistent and adjusts some strings to more clearly
indicate what KRunner is and does.

Test Plan:
{F6842587}

{F6842586}

Reviewers: #vdg, #plasma, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, plasma-devel, kde-doc-english

Tags: #plasma, #documentation

Maniphest Tasks: T10966

Differential Revision: https://phabricator.kde.org/D21343
This commit is contained in:
Nate Graham 2019-05-22 08:45:19 -06:00
parent fc79e7f4dd
commit d0c8fe9398
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
applets/kicker/plugin/computermodel.cpp
View file

@ -101,11 +101,11 @@ QVariant RunCommandModel::data(const QModelIndex &index, int role) const
}
if (role == Qt::DisplayRole) {
return i18n("Run Command...");
return i18n("Show KRunner");
} else if (role == Qt::DecorationRole) {
return QIcon::fromTheme(QStringLiteral("system-run"));
return QIcon::fromTheme(QStringLiteral("plasma-search"));
} else if (role == Kicker::DescriptionRole) {
return i18n("Run a command or a search query");
return i18n("Search, calculate, or run a command");
} else if (role == Kicker::GroupRole) {
return i18n("Applications");
}

2
design/containmentactions
View file

@ -63,7 +63,7 @@ Containment Interface
The Containment class supports loading and using containmentactions plugins.
Subclasses need do nothing to get this support. If a subclass has extra actions it wants in the
contextmenu, it can provide them in contextualActions() the same as before - but there's no longer
any need to return standard actions like "add widgets" and "run command".
any need to return standard actions like "add widgets" and "show krunner".
ContextActions plugins to use are set using the setContainmentActions(const QString &trigger, const QString &pluginName)
method. an empty string removes any plugin set for the given trigger.

2
doc/plasma-desktop/index.docbook
View file

@ -548,7 +548,7 @@ navigate through the matches using the tab and arrow keys.
</screenshot>
<para>Use the <inlinemediaobject><imageobject><imagedata fileref="krunner-configure.png" format="PNG"/>
</imageobject></inlinemediaobject> button to open the <guilabel>Plasma Search</guilabel> &systemsettings;
</imageobject></inlinemediaobject> button to open the <guilabel>KRunner</guilabel> &systemsettings;
module and configure where and what to search for in &krunner;
</para>

2
kcms/runners/kcm.cpp
View file

@ -56,7 +56,7 @@ SearchConfigModule::SearchConfigModule(QWidget* parent, const QVariantList& args
QHBoxLayout *headerLayout = new QHBoxLayout(this);
QLabel *label = new QLabel(i18n("Select the search plugins:"));
QLabel *label = new QLabel(i18n("Enable or disable KRunner plugins:"));
QPushButton *clearHistoryButton = new QPushButton(i18n("Clear History"));
clearHistoryButton->setIcon(QIcon::fromTheme(isRightToLeft() ? QStringLiteral("edit-clear-locationbar-ltr")

2
kcms/runners/kcm_plasmasearch.desktop
View file

@ -10,7 +10,7 @@ X-KDE-ParentApp=kcontrol
X-KDE-System-Settings-Parent-Category=search
X-KDE-Weight=20
Name=Plasma Search
Name=KRunner
Name[ar]=بحث بلازما
Name[bs]=Plazma pretraga
Name[ca]=Cerca de Plasma