Drop kolaTestIso() and instead run kola() after building all artifacts.
The iso.* tests are now folded into the main kola test suite, so we
build all artifacts first (metal, metal4k, live) before running tests.
With the new build-with-buildah strategy we no longer
have the rpm information in the ostree commit object
so we have to download the entire ociarchive if we want
to do RPM diffing. Download the ociarchive in the buildfetch.
Also switch to using `cosa diff` for the rpm diff part.
The `extraArgs4k` parameter no longer does anything. Just remove it so
it's clear that we're accepting the default set of tests from
`kola testiso`.
This will run more tests than before. We'll likely cut down tests we
consider redundant soon, but that should be transparent to this code.
Noticed in https://github.com/coreos/fedora-coreos-config/pull/2031 that
the `kola testiso` was killed:
FAIL: iso-offline-install (bios + metal) (1m35.505s)
signal: killed
Error: signal: killed
This is likely due to hitting up against the memory limit. It seems like
512Mi of overhead isn't enough. Let's bump it to 1Gi.
We're not currently requesting anything, which means we're at the mercy
of any default limit set on the cluster we're running on. Let's add an
explicit request.
Also bump the CPU request to 4 from the default of 2.
This adds iso-live-login and iso-as-disk scenarios, plus tests on metal4k,
multipath, and UEFI. It also drops the iso-install scenario, which isn't
a typical use case for FCOS.
We might as well enable overrides support on all mechanical streams
while we're at it.
Eventually, we should move our stream definitions into coreos-ci-lib to
have it in one canonical place.
In the majority of cases, we don't expect new builds to downgrade RPMs.
Let's default to erroring out and contributors can consciously override
CI if was really expected.
Instead of checking out the repo directly into the workspace, let's get
in the habit of checking it out into a subdirectory to keep things
clean.
This also helps code which look at the name of the directory in which
the repo is checked out, such as kola external host test handling.
This makes use of a new custom step:
https://github.com/coreos/coreos-ci-lib/pull/40
I've had syntax errors in shell script in `overlay.d` too many
times, let's add a quick check for this. This is a more lightweight
version of what we're doing in coreos-assembler.
Just do the checkout in a subdirectory in the the workspace, then point
`cosa` at it. That way we don't clone the repo twice.
This should fix CI errors when PRs are not fully rebased.
