Commit graph

459 commits

Author SHA1 Message Date
Stef Walter
fcfd5ec10a tap-phantom: Make qunit and phantomjs work well together
QUnit and phantomjs interact poorly. By overriding window.onerror
before QUnit.start(), QUnit catches errors during loading such
as syntax errors. It correctly returns false from its window.onerror
handler, however phantomjs does not act like a browser here. A false
return should normally cause the default behavior, but phantomjs
doesn't do this.

So we unset window.onerror until everything has loaded and the
unit tests have started, at which point we put back the QUnit
window.onerror handler.

Build our own qunit.js, along with qunit-tap, and our own custom
javascript at the end, which comes from qunit-config.js

Move the QUnit settings into qunit-config.js

Add checks for test cases that don't include qunit.js properly or
don't call QUnit.start() at some point. Bail out of testing when
this is the case. This results in a skipped test.

Add a test-dummy.html test case for verifying that this works, and
also as an example of how to write a pure html test, and have it
run by the automake TAP infrastructure.

Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
2014-02-27 15:35:44 +02:00
Stef Walter
8de2a5e424 tools: Move js-lint and minify into the tools directory
Reviewed-by: Marius Vollmer <marius.vollmer@redhat.com>
2014-02-27 15:08:16 +02:00
Stef Walter
733c60efa2 Makefile: Remove --disable-introspection from distcheck flags
Reviewed-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2014-02-18 10:06:06 +01:00
Stef Walter
02b02e949f Implement TAP for our testing
This way we can integrate test results from multiple sources.

After the tests have run, you'll see a summary of how many tests
were run. Details of the failed tests are available in
$(builddir)/testsuite.log.

Using TAP with automake requires a special test driver. Instead
of using the inflexible one that comes with automake, we define
our own. It's very important to see stderr failures in our
build logs and CI.

Since we can't depend on the TAP support in glib versions later
than 2.38.x this commit also includes a test output compiler
that converts GTest output to TAP.

Fixes #210

Reviewed-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2014-02-18 09:43:15 +01:00
Stef Walter
0cd3354b5d Only dist and #include the libgsystem header we need
We can't distribute all of libgsystem in our tarball, since
distros start complaining.
2014-02-13 13:58:06 +01:00
Stef Walter
75608d111f Makefile.am: Remove invalid -I$(top_builddir)/src directory
We don't use AM_INIT_AUTOMAKE "subdir-objects" option so ./src
does not exist as a subdirectory in builddir when doing out of
tree builds.

This fixes the warning:

cc1: warning: ./src: No such file or directory [enabled by default]
2014-02-13 13:58:06 +01:00
Stef Walter
5e1faadae0 Don't link to libgsystem, just use the headers
This is necessary to get through packaging blockages.

Closes #194

Signed-off-by: Marius Vollmer <mvollmer@redhat.com>
2014-02-04 15:00:17 +02:00
Marius Vollmer
68d3c1e955 Storage: Use storaged instead of patched UDisks2.
Closes: #190

Signed-off-by: Stef Walter <stefw@redhat.com>
2014-02-03 10:29:18 +01:00
Cockpit Developers
87325b96bc Initial commit 2013-11-01 13:42:29 -04:00