quine-global-labs/mirror-cockpit-project-cockpit
1
0
Fork 0
mirror of https://github.com/cockpit-project/cockpit.git synced 2026-11-03 21:49:50 -09:00
Code Issues Projects Releases Packages Wiki Activity

HACKING: Keep your PR!

Browse source 
We've seen contributors close their PRs after each review and open a new
one. Don't do that.
This commit is contained in:
Martin Pitt 2024-02-07 16:57:07 +01:00 committed by Martin Pitt
parent 2a26eb407f
commit e8967c5385
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
HACKING.md
View file

@ -378,14 +378,18 @@ A local cache is maintained in `~/.cache/cockpit-dev`.
Make a pull request on github.com with your change. All changes get reviewed,
tested, and iterated on before getting into Cockpit. The general workflow is
described in the [wiki](https://github.com/cockpit-project/cockpit/wiki/Workflow).
Don't feel bad if there's multiple steps back and forth asking for changes or
tweaks before your change gets in.
You need to be familiar with git to contribute a change. Do your changes
on a branch. Your change should be one or more git commits that each contain one
single logical simple reviewable change, without modifications that are
unrelated to the commit message.
Don't feel bad if there's multiple steps back and forth asking for changes or
tweaks before your change gets in. If you fix your commits after getting a
review, just force-push to your branch -- this will update the pull request
automatically. Do *not* close it and open a new one; that would destroy the
conversation and reviews.
Cockpit is a designed project. Anything that the user will see should have
design done first. This is done on the wiki and mailing list.