From e2c433478c74efff10262145ae074ba0a7406c3a Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Tue, 3 Nov 2026 09:25:33 +0100 Subject: [PATCH] test: Fix wait_attr type ph_has_attr uses `getAttribute()` which returns a string containing the attribute value or null. --- test/common/testlib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/common/testlib.py b/test/common/testlib.py index e2efc7cf9d..e4dc1af941 100644 --- a/test/common/testlib.py +++ b/test/common/testlib.py @@ -903,7 +903,7 @@ class Browser: self.wait_visible(selector) self.wait_js_func('!ph_has_val', selector, val) - def wait_attr(self, selector: str, attr: str, val: object) -> None: + def wait_attr(self, selector: str, attr: str, val: str | None) -> None: self._wait_present(selector) self.wait_js_func('ph_has_attr', selector, attr, val)