Fix typos throughout codebase (#23813)

Several typos and common misspellings of words exists throughout Cockpit. This fixes the spellings.

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -123,7 +123,7 @@ body:
       description: |
         (Multiple choices available.) Browser information helps with debugging, especially if things look odd or if pages are blank.
 
-        If your browser isn't in the list, select other and mention in the explaination text entry above.
+        If your browser isn't in the list, select other and mention in the explanation text entry above.
       multiple: true
       options:
         - Firefox

pkg/base1/test-file.ts

@@ -10,7 +10,7 @@ QUnit.test("simple read", async assert => {
     assert.equal(await file.read(), "1234\n", "correct result");
 });
 
-QUnit.test("read non-existant", async assert => {
+QUnit.test("read non-existent", async assert => {
     assert.equal(await cockpit.file(dir + "/blah").read(), null, "correct result");
 });
 
@@ -387,7 +387,7 @@ QUnit.test("watching without reading pre-created", async assert => {
     const file = cockpit.file(dir + "/fsinfo");
     await file.replace("1234");
     const watch = file.watch((content, tag) => {
-        assert.equal(content, null, "non-existant because read is false");
+        assert.equal(content, null, "non-existent because read is false");
         assert.notEqual(tag, null, "non empty tag");
         cockpit.assert(tag !== null, "tag is null");
         assert.equal(tag.startsWith("1:"), true, "tag always starts with 1:");

pkg/base1/test-metrics.js

@@ -183,7 +183,7 @@ QUnit.test("metrics object validation", assert => {
         source: "internal",
         interval: 1000,
         metrics: [
-            { name: "nonexistant", derive: "rate" },
+            { name: "nonexistent", derive: "rate" },
         ]
     });
 

pkg/lib/_internal/packagekit.ts

@@ -146,7 +146,7 @@ export class PackageKitManager implements PackageManager {
         let last_info = 0;
         let last_name = "";
 
-        function report_progess() {
+        function report_progress() {
             if (progress_cb && last_progress !== null)
                 progress_cb({
                     waiting: last_progress.waiting,
@@ -162,13 +162,13 @@ export class PackageKitManager implements PackageManager {
         await PK.cancellableTransaction("InstallPackages", [0, data.missing_ids],
                                         (p: ProgressData) => {
                                             last_progress = p;
-                                            report_progess();
+                                            report_progress();
                                         },
                                         {
                                             Package: (info: number, id: string) => {
                                                 last_info = info;
                                                 last_name = id.split(";")[0];
-                                                report_progess();
+                                                report_progress();
                                             }
                                         });
     }

pkg/networkmanager/firewall-client.js

@@ -544,7 +544,7 @@ firewall.activateZone = (zone, interfaces, sources) => {
 /*
  * A zone is considered deactivated when it has no interfaces or sources.
  */
-firewall.deactiveateZone = (zone) => {
+firewall.deactivateZone = (zone) => {
     const zoneObject = firewall.zones[zone];
     let promises = zoneObject.interfaces.map(i => firewalld_dbus.call('/org/fedoraproject/FirewallD1',
                                                                       'org.fedoraproject.FirewallD1.zone',

pkg/networkmanager/firewall.jsx

@@ -986,7 +986,7 @@ export class Firewall extends React.Component {
                                               target={zone}
                                               onCancel={Dialogs.close}
                                               onDelete={ () => {
-                                                  firewall.deactiveateZone(zone);
+                                                  firewall.deactivateZone(zone);
                                                   Dialogs.close();
                                               }} />
         );

pkg/shell/machines/machines.d.ts

@@ -34,7 +34,7 @@ interface MachinesEvents extends EventMap {
 export interface Machines extends EventSource<MachinesEvents> {
     ready: boolean;
 
-    lookup: (conection_string: string) => Machine;
+    lookup: (connection_string: string) => Machine;
     list: Machine[];
     change: (key: string, props: Partial<Machine>) => void;
 }

pkg/shell/state.tsx

@@ -207,7 +207,7 @@ export class ShellState extends EventEmitter<ShellStateEvents> {
     #ensure_frame(machine: Machine, path: string, hash: string | null, title: string): ShellFrame | null {
         /* Never create new frames for machines that are not
            connected yet. That would open a channel to them (for
-           loading the URL), which woould trigger the bridge to
+           loading the URL), which would trigger the bridge to
            attempt a log in. We want all logins to happen in a
            single place (in hosts.jsx) so that we can get the
            options right, and show a warning dialog.

pkg/storaged/btrfs/filesystem.jsx

@@ -22,7 +22,7 @@ const _ = cockpit.gettext;
 
 /**
  * For single btrfs volumes we show the data as a filesystem card with the
- * subvolumes directly undernearth. This differentiates from multi device
+ * subvolumes directly underneath. This differentiates from multi device
  * volumes, there they are shown under a different card.
  */
 export function make_btrfs_filesystem_card(next, backing_block, content_block) {

pkg/users/account-details.js

@@ -124,7 +124,7 @@ export function AccountDetails({ account, groups, isLoading, current_user, shell
 
     const [editedRealName, setEditedRealName] = useState(null);
     const [realNameError, setRealNameError] = useState("");
-    const [comittingRealName, setCommittingRealName] = useState(false);
+    const [committingRealName, setCommittingRealName] = useState(false);
     const [disableLockedEdit, setDisableLockedEdit] = useState(false);
 
     useEffect(() => {
@@ -262,7 +262,7 @@ export function AccountDetails({ account, groups, isLoading, current_user, shell
                                     { superuser.allowed
                                         ? <>
                                             <TextInput id="account-real-name"
-                                                     isDisabled={comittingRealName || account.uid == 0}
+                                                     isDisabled={committingRealName || account.uid == 0}
                                                      value={editedRealName !== null ? editedRealName : account.gecos}
                                                      onKeyDown={event => {
                                                          if (event.key == "Enter") {

selinux/cockpit.if

@@ -2,7 +2,7 @@
 
 ########################################
 ## <summary>
-##	Execute TEMPLATE in the cockpit domin.
+##	Execute TEMPLATE in the cockpit domain.
 ## </summary>
 ## <param name="domain">
 ## <summary>
@@ -21,7 +21,7 @@ interface(`cockpit_ws_domtrans',`
 
 ########################################
 ## <summary>
-##	Execute TEMPLATE in the cockpit domin.
+##	Execute TEMPLATE in the cockpit domain.
 ## </summary>
 ## <param name="domain">
 ## <summary>

src/pam-ssh-add/pam-ssh-add.c

@@ -613,7 +613,7 @@ done:
 int
 pam_ssh_add_start_agent (pam_handle_t *pamh,
                          struct passwd *pwd,
-                         const char *xdg_runtime_overide,
+                         const char *xdg_runtime_override,
                          char **out_auth_sock_var,
                          char **out_agent_pid_var)
 {
@@ -642,7 +642,7 @@ pam_ssh_add_start_agent (pam_handle_t *pamh,
 
   assert (pwd);
   xdg_runtime = get_optional_env ("XDG_RUNTIME_DIR",
-                                  xdg_runtime_overide);
+                                  xdg_runtime_override);
   if (!build_environment (env,
                           "PATH", PATH,
                           "LC_ALL", "C",

src/pam-ssh-add/pam-ssh-add.h

@@ -22,7 +22,7 @@ extern pam_ssh_add_logger pam_ssh_add_log_handler;
 
 int     pam_ssh_add_start_agent     (pam_handle_t *pamh,
                                      struct passwd *pwd,
-                                     const char *xdg_runtime_overide,
+                                     const char *xdg_runtime_override,
                                      char **out_auth_sock_var,
                                      char **out_agent_pid_var);
 

src/pam-ssh-add/test-ssh-add.c

@@ -218,7 +218,7 @@ test_environment (Fixture *fix,
 }
 
 static void
-test_environment_env_overides (Fixture *fix,
+test_environment_env_overrides (Fixture *fix,
                                gconstpointer user_data)
 {
   setenv ("PATH", "bad", 1);
@@ -232,7 +232,7 @@ test_environment_env_overides (Fixture *fix,
 }
 
 static void
-test_environment_overides (Fixture *fix,
+test_environment_overrides (Fixture *fix,
                            gconstpointer user_data)
 {
   setenv ("XDG_RUNTIME_DIR", "bad", 1);
@@ -399,10 +399,10 @@ main (int argc,
 
   g_test_add ("/pam-ssh-add/environment", Fixture, &environment_fixture,
               setup, test_environment, teardown);
-  g_test_add ("/pam-ssh-add/environment-env-overides", Fixture, &environment_fixture,
+  g_test_add ("/pam-ssh-add/environment-env-overrides", Fixture, &environment_fixture,
-              setup, test_environment_env_overides, teardown);
+              setup, test_environment_env_overrides, teardown);
-  g_test_add ("/pam-ssh-add/environment-overides", Fixture, &environment_fixture,
+  g_test_add ("/pam-ssh-add/environment-overrides", Fixture, &environment_fixture,
-              setup, test_environment_overides, teardown);
+              setup, test_environment_overrides, teardown);
   g_test_add ("/pam-ssh-add/good-agent-vars", Fixture, &good_agent_fixture,
               setup, test_good_agent_vars, teardown);
   g_test_add ("/pam-ssh-add/bad-agent-vars", Fixture, &bad_agent_fixture,

src/testlib/cockpittest.c

@@ -40,7 +40,7 @@ typedef struct {
   const gchar *file;
   int line;
   const gchar *func;
-  gboolean skipable;
+  gboolean skippable;
   gboolean optional;
 } ExpectedMessage;
 
@@ -128,7 +128,7 @@ expected_message_handler (const gchar *log_domain,
           g_test_log_set_fatal_handler (expected_fatal_handler, NULL);
         }
 
-      /* Loop until we find a non-skipable message or have a match */
+      /* Loop until we find a non-skippable message or have a match */
       for (l = expected_messages; l != NULL; l = l->next)
         {
           expected = l->data;
@@ -141,7 +141,7 @@ expected_message_handler (const gchar *log_domain,
               skip = TRUE;
               break;
             }
-          else if (!expected->skipable)
+          else if (!expected->skippable)
             {
               break;
             }
@@ -223,7 +223,7 @@ _cockpit_expect_logged_msg (const char *domain,
                             const gchar *func,
                             GLogLevelFlags log_level,
                             const gchar *pattern,
-                            gboolean skipable,
+                            gboolean skippable,
                             gboolean optional)
 {
   ExpectedMessage *expected;
@@ -242,7 +242,7 @@ _cockpit_expect_logged_msg (const char *domain,
   expected->file = file;
   expected->line = line;
   expected->func = func;
-  expected->skipable = optional ? TRUE : skipable;
+  expected->skippable = optional ? TRUE : skippable;
   expected->optional = optional;
 
   G_LOCK (expected);

src/testlib/cockpittest.h

@@ -23,7 +23,7 @@ void     _cockpit_expect_logged_msg         (const char *domain,
                                              const char *func,
                                              GLogLevelFlags log_level,
                                              const gchar *pattern,
-                                             gboolean skipable,
+                                             gboolean skippable,
                                              gboolean optional);
 
 #define cockpit_expect_log(domain, level, pattern) \

src/ws/test-pipe.c

@@ -267,7 +267,7 @@ test_echo_large (TestCase *tc,
 
   g_byte_array_set_size (echo_pipe->received, 0);
 
-  /* Double check that didn't csrew things up */
+  /* Double check that didn't screw things up */
   sent = g_bytes_new_static ("yello", 5);
   cockpit_pipe_write (tc->pipe, sent);
   while (echo_pipe->received->len < g_bytes_get_size (sent))

src/ws/test-transport.c

@@ -286,7 +286,7 @@ test_echo_large (TestCase *tc,
   g_bytes_unref (received);
   received = NULL;
 
-  /* Double check that didn't csrew things up */
+  /* Double check that didn't screw things up */
   sent = g_bytes_new_static ("yello", 5);
   cockpit_transport_send (tc->transport, "546", sent);
   WAIT_UNTIL (received != NULL);

src/ws/test-webresponse.c

@@ -293,7 +293,7 @@ test_file_slash_denied (TestCase *tc,
 }
 
 static void
-test_file_breakout_non_existant (TestCase *tc,
+test_file_breakout_non_existent (TestCase *tc,
                                  gconstpointer user_data)
 {
   gchar *root = realpath ( SRCDIR "/src", NULL);
@@ -999,7 +999,7 @@ test_web_filter_passthrough (TestCase *tc,
 }
 
 static void
-on_response_done_not_resuable (CockpitWebResponse *response,
+on_response_done_not_reusable (CockpitWebResponse *response,
                                gboolean reusable,
                                gpointer user_data)
 {
@@ -1014,7 +1014,7 @@ test_abort (TestCase *tc,
   GBytes *content;
 
   cockpit_web_response_headers (tc->response, 200, "OK", 11, NULL);
-  g_signal_connect (tc->response, "done", G_CALLBACK (on_response_done_not_resuable), NULL);
+  g_signal_connect (tc->response, "done", G_CALLBACK (on_response_done_not_reusable), NULL);
 
   while (g_main_context_iteration (NULL, FALSE));
 
@@ -1044,7 +1044,7 @@ test_connection_close (TestCase *tc,
 
   g_assert (data == &fixture_connection_close);
 
-  g_signal_connect (tc->response, "done", G_CALLBACK (on_response_done_not_resuable), NULL);
+  g_signal_connect (tc->response, "done", G_CALLBACK (on_response_done_not_reusable), NULL);
 
   content = g_bytes_new_static ("the content", 11);
   cockpit_web_response_content (tc->response, NULL, content, NULL);
@@ -1417,8 +1417,8 @@ main (int argc,
               setup, test_file_encoding_denied, teardown);
   g_test_add ("/web-response/file/file-slash-denied", TestCase, NULL,
               setup, test_file_slash_denied, teardown);
-  g_test_add ("/web-response/file/breakout-non-existant", TestCase, NULL,
+  g_test_add ("/web-response/file/breakout-non-existent", TestCase, NULL,
-              setup, test_file_breakout_non_existant, teardown);
+              setup, test_file_breakout_non_existent, teardown);
   g_test_add ("/web-reponse/file/template", TestCase, &template_fixture,
               setup, test_template, teardown);
   g_test_add ("/web-response/content-type/html", TestCase, &content_type_fixture_html,

test/common/testlib.py

@@ -1787,7 +1787,7 @@ class MachineCase(unittest.TestCase):
             if self.is_nondestructive():
                 pass
             elif os.getenv("DESTRUCTIVE") and not self.is_nondestructive():
-                print("Run destructive test, be careful, may lead to upredictable state of machine")
+                print("Run destructive test, be careful, may lead to unpredictable state of machine")
             else:
                 raise unittest.SkipTest("Skip destructive test by default")
             if os.getenv("BROWSER"):

test/verify/check-networkmanager-wireguard

@@ -155,7 +155,7 @@ class TestWireGuard(packagelib.PackageCase, netlib.NetworkCase):
         m1.execute(f"until wg show wg0 | grep -q 'allowed ips.*{m2_ip4}/32'; do sleep 1; done")
         m1.execute(f"until ip route | grep -q '10.0.0.0/24 dev wg0 proto kernel scope link src {m1_ip4} metric 50'; do sleep 1; done")
 
-        # endpoint and port is not necessary for a peer if that peer estalishes the connectio first (i.e. the client)
+        # endpoint and port is not necessary for a peer if that peer establishes the connection first (i.e. the client)
         b2.click("button:contains('Add peer')")
         b2.set_input_text("#network-wireguard-settings-publickey-peer-0", m1_pubkey)
         b2.set_input_text("#network-wireguard-settings-allowedips-peer-0", f"{m1_ip4}/32")

test/verify/check-shell-multi-machine-key

@@ -260,7 +260,7 @@ Host 10.111.113.2
 
         # Upload id_rsa and change its password to something else so
         # that it is not automatically loaded into the agent.  id_rsa
-        # should be tried autoamtically without needing to configure
+        # should be tried automatically without needing to configure
         # it explicitly in ~/.ssh/config.
 
         m1.execute("mkdir -p /home/admin/.ssh")

test/verify/check-storage-anaconda

@@ -163,7 +163,7 @@ class TestStorageAnaconda(storagelib.StorageCase):
         b.wait_not_present(self.card_row("Storage", location="/var"))
 
     @testlib.skipImage("No Stratis", "debian-*", "ubuntu-*", "arch")
-    @testlib.skipImage("commit 817c957899a4 removed Statis 2 support", "rhel-8-*")
+    @testlib.skipImage("commit 817c957899a4 removed Stratis 2 support", "rhel-8-*")
     @testlib.skipImage("Stratis v1 pools are unsupported", "rhel-9-*")
     def testStratis(self):
         m = self.machine

test/verify/check-storage-stratis

@@ -49,7 +49,7 @@ def create_legacy_pool(machine, disks, name="pool0", keydesc=None, tang=None):
 
 @testlib.skipImage("No Stratis", "debian-*", "ubuntu-*", "arch")
 @testlib.skipImage("stratis not installed", "*-bootc")
-@testlib.skipImage("commit 817c957899a4 removed Statis 2 support", "rhel-8-*")
+@testlib.skipImage("commit 817c957899a4 removed Stratis 2 support", "rhel-8-*")
 @testlib.nondestructive
 class TestStorageStratis(storagelib.StorageCase):
     def setUp(self):
@@ -573,7 +573,7 @@ systemctl restart stratisd
 
 @testlib.skipImage("No Stratis", "debian-*", "ubuntu-*", "arch")
 @testlib.skipImage("stratis not installed", "*-bootc")
-@testlib.skipImage("commit 817c957899a4 removed Statis 2 support", "rhel-8-*")
+@testlib.skipImage("commit 817c957899a4 removed Stratis 2 support", "rhel-8-*")
 class TestStorageStratisReboot(storagelib.StorageCase):
     def setUp(self):
         super().setUp()

test/verify/check-system-services

@@ -439,7 +439,7 @@ WantedBy=default.target
             # so we instead just wrap the whole subnav (ugly but functional).
             # https://github.com/patternfly/patternfly-react/issues/11751
 
-            # Now scroll the header all the way to the left to get a conistent pixel test result
+            # Now scroll the header all the way to the left to get a consistent pixel test result
             # nav_scroll_btn = ".services-header button[aria-label='Scroll back']"
             # while b.call_js_func("ph_attr", nav_scroll_btn, "disabled") is None:
             #     b.click(nav_scroll_btn)