No description
Find a file
Deluan Quintão 5ce6e16d96
fix: album statistics not updating after deleting missing files (#4668)
* feat: add album refresh functionality after deleting missing files

Implemented RefreshAlbums method in AlbumRepository to recalculate album attributes (size, duration, song count) from their constituent media files. This method processes albums in batches to maintain efficiency with large datasets.

Added integration in deleteMissingFiles to automatically refresh affected albums in the background after deleting missing media files, ensuring album statistics remain accurate. Includes comprehensive test coverage for various scenarios including single/multiple albums, empty batches, and large batch processing.

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: extract missing files deletion into reusable service layer

Extracted inline deletion logic from server/nativeapi/missing.go into a new core.MissingFiles service interface and implementation. This provides better separation of concerns and testability.

The MissingFiles service handles:
- Deletion of specific or all missing files via transaction
- Garbage collection after deletion
- Extraction of affected album IDs from missing files
- Background refresh of artist and album statistics

The deleteMissingFiles HTTP handler now simply delegates to the service, removing 70+ lines of inline logic. All deletion, transaction, and stat refresh logic is now centralized in core/missing_files.go.

Updated dependency injection to provide MissingFiles service to the native API router. Renamed receiver variable from 'n' to 'api' throughout native_api.go for consistency.

* refactor: consolidate maintenance operations into unified service

Consolidate MissingFiles and RefreshAlbums functionality into a new Maintenance service. This refactoring:
- Creates core.Maintenance interface combining DeleteMissingFiles, DeleteAllMissingFiles, and RefreshAlbums methods
- Moves RefreshAlbums logic from AlbumRepository persistence layer to core Maintenance service
- Removes MissingFiles interface and moves its implementation to maintenanceService
- Updates all references in wire providers, native API router, and handlers
- Removes RefreshAlbums interface method from AlbumRepository model
- Improves separation of concerns by centralizing maintenance operations in the core domain

This change provides a cleaner API and better organization of maintenance-related database operations.

* refactor: remove MissingFiles interface and update references

Remove obsolete MissingFiles interface and its references:
- Delete core/missing_files.go and core/missing_files_test.go
- Remove RefreshAlbums method from AlbumRepository interface and implementation
- Remove RefreshAlbums tests from AlbumRepository test suite
- Update wire providers to use NewMaintenance instead of NewMissingFiles
- Update native API router to use Maintenance service
- Update missing.go handler to use Maintenance interface

All functionality is now consolidated in the core.Maintenance service.

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: rename RefreshAlbums to refreshAlbums and update related calls

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: optimize album refresh logic and improve test coverage

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: simplify logging setup in tests with reusable LogHook function

Signed-off-by: Deluan <deluan@navidrome.org>

* refactor: add synchronization to logger and maintenance service for thread safety

Signed-off-by: Deluan <deluan@navidrome.org>

---------

Signed-off-by: Deluan <deluan@navidrome.org>
2025-11-08 20:11:00 -05:00
.devcontainer chore(deps): update all dependencies (#4618) 2025-10-25 17:05:16 -04:00
.github chore: update actions/upload-artifact and actions/download-artifact to latest versions 2025-11-06 12:43:35 -05:00
adapters/taglib fix(scanner): restore basic tag extraction fallback mechanism for improved metadata parsing (#4401) 2025-10-26 19:38:34 -04:00
cmd fix: album statistics not updating after deleting missing files (#4668) 2025-11-08 20:11:00 -05:00
conf feat(insights): add plugin and multi-library information (#4391) 2025-07-28 13:21:10 -04:00
consts feat(scanner): add Scanner.PurgeMissing configuration option (#4107) 2025-05-22 20:50:15 -04:00
contrib build: add packages for deb and rpm to release (#3202) 2024-10-26 13:31:45 -04:00
core fix: album statistics not updating after deleting missing files (#4668) 2025-11-08 20:11:00 -05:00
db fix(db): make playqueue position field an integer (#4481) 2025-11-06 14:41:09 -05:00
git feat(plugins): experimental support for plugins (#3998) 2025-06-22 20:45:38 -04:00
log fix: album statistics not updating after deleting missing files (#4668) 2025-11-08 20:11:00 -05:00
model fix: enable multi-valued releasetype in smart playlists (#4621) 2025-10-26 19:36:44 -04:00
persistence fix(ui): correct track ordering when sorting playlists by album (#4657) 2025-11-06 16:50:54 -05:00
plugins feat(insights): add plugin and multi-library information (#4391) 2025-07-28 13:21:10 -04:00
release chore: fix some typos in comment and logs (#4333) 2025-07-13 14:31:15 -04:00
resources fix(ui): fix Playlist Italian translation(#4642) 2025-11-07 18:41:23 -05:00
scanner chore(deps): update all dependencies (#4618) 2025-10-25 17:05:16 -04:00
scheduler feat(plugins): experimental support for plugins (#3998) 2025-06-22 20:45:38 -04:00
server fix: album statistics not updating after deleting missing files (#4668) 2025-11-08 20:11:00 -05:00
tests fix: album statistics not updating after deleting missing files (#4668) 2025-11-08 20:11:00 -05:00
ui fix(ui): resolve transparent dropdown background in Ligera theme (#4665) 2025-11-08 12:47:02 -05:00
utils refactor: extract TruncateRunes function for safe string truncation with suffix 2025-11-06 14:27:38 -05:00
.dockerignore fix(insights): fix issues and improve reports (#3558) 2024-12-18 20:37:35 -05:00
.git-blame-ignore-revs Move project to Navidrome GitHub organization 2021-02-06 21:47:19 -05:00
.gitignore test: improve serve_index_test code 2025-06-28 20:01:47 -04:00
.golangci.yml chore(deps) upgrade Go dependencies, including golangci-lint (#3937) 2025-04-07 19:42:00 -03:00
.nvmrc chore(deps): update all dependencies (#4618) 2025-10-25 17:05:16 -04:00
CODE_OF_CONDUCT.md Use Contributor Covenant v2.0 2020-07-21 14:40:21 -04:00
CONTRIBUTING.md build(ci): change GitHub release notes (#3300) 2024-09-21 17:00:13 -04:00
Dockerfile build(docker): use standalone wget instead of the busybox one, fix #4473 2025-10-25 17:47:09 -04:00
go.mod fix: update wazero dependency to resolve ARM64 SIGILL crash (#4655) 2025-11-06 15:07:09 -05:00
go.sum fix: update wazero dependency to resolve ARM64 SIGILL crash (#4655) 2025-11-06 15:07:09 -05:00
LICENSE Change license to GPLv3 2020-01-22 14:48:38 -05:00
main.go build(netgo): make sure the project is always compiled with netgo build tag (#3428) 2024-10-26 13:28:23 -04:00
Makefile build: enhance golangci-lint installation process to check version and reinstall if necessary 2025-10-25 17:42:33 -04:00
Procfile.dev chore(deps): upgrade to Go 1.24.1 (#3851) 2025-03-17 21:08:10 -04:00
README.md feat: add Navidrome Guru on Gurubase.io (#3491) 2024-11-23 17:29:00 -05:00
reflex.conf feat(plugins): experimental support for plugins (#3998) 2025-06-22 20:45:38 -04:00

Navidrome logo

Navidrome Music Server  Tweet

Last Release Build Downloads Docker Pulls Dev Chat Subreddit Contributor Covenant Gurubase

Navidrome is an open source web-based music collection server and streamer. It gives you freedom to listen to your music collection from any browser or mobile device. It's like your personal Spotify!

Note: The master branch may be in an unstable or even broken state during development. Please use releases instead of the master branch in order to get a stable set of binaries.

Check out our Live Demo!

Any feedback is welcome! If you need/want a new feature, find a bug or think of any way to improve Navidrome, please file a GitHub issue or join the discussion in our Subreddit. If you want to contribute to the project in any other way (ui/backend dev, translations, themes), please join the chat in our Discord server.

Installation

See instructions on the project's website

Cloud Hosting

PikaPods has partnered with us to offer you an officially supported, cloud-hosted solution. A share of the revenue helps fund the development of Navidrome at no additional cost for you.

PikaPods

Features

  • Handles very large music collections
  • Streams virtually any audio format available
  • Reads and uses all your beautifully curated metadata
  • Great support for compilations (Various Artists albums) and box sets (multi-disc albums)
  • Multi-user, each user has their own play counts, playlists, favourites, etc...
  • Very low resource usage
  • Multi-platform, runs on macOS, Linux and Windows. Docker images are also provided
  • Ready to use binaries for all major platforms, including Raspberry Pi
  • Automatically monitors your library for changes, importing new files and reloading new metadata
  • Themeable, modern and responsive Web interface based on Material UI
  • Compatible with all Subsonic/Madsonic/Airsonic clients
  • Transcoding on the fly. Can be set per user/player. Opus encoding is supported
  • Translated to various languages

Translations

Navidrome uses POEditor for translations, and we are always looking for more contributors

Documentation

All documentation can be found in the project's website: https://www.navidrome.org/docs. Here are some useful direct links:

Screenshots