* refactor: rename ArtistRadio to SimilarSongs for clarity and consistency Signed-off-by: Deluan <deluan@navidrome.org> * feat: implement GetSimilarSongsByTrack and related functionality for song similarity retrieval Signed-off-by: Deluan <deluan@navidrome.org> * feat: enhance GetSimilarSongsByTrack to include artist and album details and update tests Signed-off-by: Deluan <deluan@navidrome.org> * feat: enhance song matching by implementing title and artist filtering in loadTracksByTitleAndArtist Signed-off-by: Deluan <deluan@navidrome.org> * test: add unit tests for song matching functionality in provider Signed-off-by: Deluan <deluan@navidrome.org> * refactor: extract song matching functionality into its own file Signed-off-by: Deluan <deluan@navidrome.org> * docs: clarify similarSongsFallback function description in provider.go Signed-off-by: Deluan <deluan@navidrome.org> * refactor: initialize result slice for songs with capacity based on response length Signed-off-by: Deluan <deluan@navidrome.org> * refactor: simplify agent method calls for retrieving images and similar songs Signed-off-by: Deluan <deluan@navidrome.org> * refactor: simplify agent method calls for retrieving images and similar songs Signed-off-by: Deluan <deluan@navidrome.org> * refactor: remove outdated comments in GetSimilarSongs methods Signed-off-by: Deluan <deluan@navidrome.org> * fix: use composite key for song matches to handle duplicates by title and artist Signed-off-by: Deluan <deluan@navidrome.org> * refactor: consolidate expectations setup for similar songs tests Signed-off-by: Deluan <deluan@navidrome.org> * feat: add instant mix action to song context menu and update translations Signed-off-by: Deluan <deluan@navidrome.org> * fix(provider): handle unknown entity types in GetSimilarSongs Signed-off-by: Deluan <deluan@navidrome.org> * refactor: move playSimilar action to playbackActions and streamline song processing Signed-off-by: Deluan <deluan@navidrome.org> * format Signed-off-by: Deluan <deluan@navidrome.org> * feat: enhance instant mix functionality with loading notification and shuffle option Signed-off-by: Deluan <deluan@navidrome.org> * feat: implement fuzzy matching for similar songs based on configurable threshold Signed-off-by: Deluan <deluan@navidrome.org> * refactor: implement track matching with multiple specificity levels Signed-off-by: Deluan <deluan@navidrome.org> * refactor: enhance track matching by implementing unified scoring with specificity levels Signed-off-by: Deluan <deluan@navidrome.org> * feat: enhance deezer top tracks result with album Signed-off-by: Deluan <deluan@navidrome.org> * feat: enhance track matching with fuzzy album similarity for improved scoring Signed-off-by: Deluan <deluan@navidrome.org> * docs: document multi-phase song matching algorithm with detailed scoring and prioritization Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
227 lines
6.6 KiB
JavaScript
227 lines
6.6 KiB
JavaScript
import React from 'react'
|
|
import { render, fireEvent, screen, waitFor } from '@testing-library/react'
|
|
import { TestContext } from 'ra-test'
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { SongContextMenu } from './SongContextMenu'
|
|
import subsonic from '../subsonic'
|
|
|
|
vi.mock('../dataProvider', () => ({
|
|
httpClient: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('../subsonic', () => ({
|
|
default: { getSimilarSongs2: vi.fn() },
|
|
}))
|
|
|
|
vi.mock('../config', () => ({
|
|
default: {
|
|
enableDownloads: true,
|
|
enableFavourites: true,
|
|
enableSharing: true,
|
|
enableExternalServices: true,
|
|
},
|
|
}))
|
|
|
|
const mockDispatch = vi.fn()
|
|
vi.mock('react-redux', () => ({ useDispatch: () => mockDispatch }))
|
|
|
|
const getPlaylistsMock = vi.fn()
|
|
const mockNotify = vi.fn()
|
|
|
|
vi.mock('react-admin', async (importOriginal) => {
|
|
const actual = await importOriginal()
|
|
return {
|
|
...actual,
|
|
useNotify: () => mockNotify,
|
|
useRedirect: () => (url) => {
|
|
window.location.hash = `#${url}`
|
|
},
|
|
useDataProvider: () => ({
|
|
getPlaylists: getPlaylistsMock,
|
|
inspect: vi.fn().mockResolvedValue({
|
|
data: { rawTags: {} },
|
|
}),
|
|
}),
|
|
}
|
|
})
|
|
|
|
describe('SongContextMenu', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
window.location.hash = ''
|
|
getPlaylistsMock.mockResolvedValue({
|
|
data: [{ id: 'pl1', name: 'Pl 1' }],
|
|
})
|
|
subsonic.getSimilarSongs2.mockResolvedValue({
|
|
json: {
|
|
'subsonic-response': {
|
|
status: 'ok',
|
|
similarSongs2: { song: [{ id: 's1' }] },
|
|
},
|
|
},
|
|
})
|
|
})
|
|
|
|
it('navigates to playlist when selected', async () => {
|
|
render(
|
|
<TestContext>
|
|
<SongContextMenu record={{ id: 'song1', size: 1 }} resource="song" />
|
|
</TestContext>,
|
|
)
|
|
fireEvent.click(screen.getAllByRole('button')[1])
|
|
await waitFor(() =>
|
|
screen.getByText(/resources\.song\.actions\.showInPlaylist/),
|
|
)
|
|
fireEvent.click(
|
|
screen.getByText(/resources\.song\.actions\.showInPlaylist/),
|
|
)
|
|
await waitFor(() => screen.getByText('Pl 1'))
|
|
fireEvent.click(screen.getByText('Pl 1'))
|
|
expect(window.location.hash).toBe('#/playlist/pl1/show')
|
|
})
|
|
|
|
it('stops event propagation when playlist submenu is closed', async () => {
|
|
const mockOnClick = vi.fn()
|
|
render(
|
|
<TestContext>
|
|
<div onClick={mockOnClick}>
|
|
<SongContextMenu record={{ id: 'song1', size: 1 }} resource="song" />
|
|
</div>
|
|
</TestContext>,
|
|
)
|
|
|
|
// Open main menu
|
|
fireEvent.click(screen.getAllByRole('button')[1])
|
|
await waitFor(() =>
|
|
screen.getByText(/resources\.song\.actions\.showInPlaylist/),
|
|
)
|
|
|
|
// Open playlist submenu
|
|
fireEvent.click(
|
|
screen.getByText(/resources\.song\.actions\.showInPlaylist/),
|
|
)
|
|
await waitFor(() => screen.getByText('Pl 1'))
|
|
|
|
// Click outside the playlist submenu (should close it without triggering parent click)
|
|
fireEvent.click(document.body)
|
|
|
|
expect(mockOnClick).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('does nothing when "Show in Playlist" is disabled', async () => {
|
|
getPlaylistsMock.mockResolvedValue({ data: [] })
|
|
const mockOnClick = vi.fn()
|
|
render(
|
|
<TestContext>
|
|
<div onClick={mockOnClick}>
|
|
<SongContextMenu record={{ id: 'song1', size: 1 }} resource="song" />
|
|
</div>
|
|
</TestContext>,
|
|
)
|
|
|
|
fireEvent.click(screen.getAllByRole('button')[1])
|
|
await waitFor(() =>
|
|
screen.getByText(/resources\.song\.actions\.showInPlaylist/),
|
|
)
|
|
|
|
fireEvent.click(
|
|
screen.getByText(/resources\.song\.actions\.showInPlaylist/),
|
|
)
|
|
expect(mockOnClick).not.toHaveBeenCalled()
|
|
})
|
|
|
|
describe('Instant Mix action', () => {
|
|
it('calls getSimilarSongs2 with song id and shows loading notification', async () => {
|
|
render(
|
|
<TestContext>
|
|
<SongContextMenu record={{ id: 'song1', size: 1 }} resource="song" />
|
|
</TestContext>,
|
|
)
|
|
|
|
fireEvent.click(screen.getAllByRole('button')[1])
|
|
await waitFor(() =>
|
|
screen.getByText(/resources\.song\.actions\.instantMix/),
|
|
)
|
|
fireEvent.click(screen.getByText(/resources\.song\.actions\.instantMix/))
|
|
|
|
// Verify loading notification is shown
|
|
expect(mockNotify).toHaveBeenCalledWith('message.startingInstantMix', {
|
|
type: 'info',
|
|
})
|
|
|
|
await waitFor(() =>
|
|
expect(subsonic.getSimilarSongs2).toHaveBeenCalledWith('song1', 100),
|
|
)
|
|
expect(mockDispatch).toHaveBeenCalled()
|
|
})
|
|
|
|
it('plays seed song first followed by similar songs', async () => {
|
|
const seedRecord = { id: 'song1', title: 'Seed Song', size: 1 }
|
|
render(
|
|
<TestContext>
|
|
<SongContextMenu record={seedRecord} resource="song" />
|
|
</TestContext>,
|
|
)
|
|
|
|
fireEvent.click(screen.getAllByRole('button')[1])
|
|
await waitFor(() =>
|
|
screen.getByText(/resources\.song\.actions\.instantMix/),
|
|
)
|
|
fireEvent.click(screen.getByText(/resources\.song\.actions\.instantMix/))
|
|
|
|
await waitFor(() => expect(mockDispatch).toHaveBeenCalled())
|
|
|
|
// Verify dispatch was called with playTracks action
|
|
const dispatchCall = mockDispatch.mock.calls.find(
|
|
(call) => call[0]?.type === 'PLAYER_PLAY_TRACKS',
|
|
)
|
|
expect(dispatchCall).toBeDefined()
|
|
|
|
// Verify seed song is first (id property contains the first song to play)
|
|
const { id, data } = dispatchCall[0]
|
|
expect(id).toBe('song1')
|
|
// Verify seed song data is included
|
|
expect(data['song1']).toBeDefined()
|
|
})
|
|
|
|
it('uses mediaFileId when available (playlist context)', async () => {
|
|
render(
|
|
<TestContext>
|
|
<SongContextMenu
|
|
record={{
|
|
id: 'playlistTrackId',
|
|
mediaFileId: 'actualSongId',
|
|
size: 1,
|
|
}}
|
|
resource="song"
|
|
/>
|
|
</TestContext>,
|
|
)
|
|
|
|
fireEvent.click(screen.getAllByRole('button')[1])
|
|
await waitFor(() =>
|
|
screen.getByText(/resources\.song\.actions\.instantMix/),
|
|
)
|
|
fireEvent.click(screen.getByText(/resources\.song\.actions\.instantMix/))
|
|
|
|
await waitFor(() =>
|
|
expect(subsonic.getSimilarSongs2).toHaveBeenCalledWith(
|
|
'actualSongId',
|
|
100,
|
|
),
|
|
)
|
|
|
|
await waitFor(() => expect(mockDispatch).toHaveBeenCalled())
|
|
|
|
// Verify the mediaFileId is used as the seed song id
|
|
const dispatchCall = mockDispatch.mock.calls.find(
|
|
(call) => call[0]?.type === 'PLAYER_PLAY_TRACKS',
|
|
)
|
|
expect(dispatchCall).toBeDefined()
|
|
const { id, data } = dispatchCall[0]
|
|
expect(id).toBe('actualSongId')
|
|
// Verify seed song data is included
|
|
expect(data['actualSongId']).toBeDefined()
|
|
})
|
|
})
|
|
})
|