quintodrome/ui/src
Deluan Quintão 445880c006
fix(ui): prevent disabled Show in Playlist menu item from triggering actions (#4356)
* fix: prevent disabled Show in Playlist menu item from triggering actions

Fixed bug where clicking on the disabled 'Show in Playlist' menu item would unintentionally trigger music playback and replace the queue. The menu item now properly prevents event propagation when disabled and takes no action.

This resolves the issue where users would accidentally start playing music when clicking on the greyed-out menu option. The fix includes:
- Custom onClick handler that stops event propagation for disabled state
- Proper styling to maintain visual disabled state while allowing event handling
- Comprehensive test coverage for the disabled behavior

* style: clean up disabled menu item styling code

Simplified the arrow function for disabled onClick handler and changed inline style from empty object to undefined when not needed. Also added a CSS class for disabled menu items for potential future use.

These changes improve code readability and follow React best practices by using undefined instead of empty objects for conditional styles.
2025-07-17 11:00:12 -04:00
..
actions fix(ui): keep the NowPlayingPanel badge in sync. 2025-06-29 11:35:10 -04:00
album fix(ui): don't show year "0" 2025-07-15 19:12:25 -04:00
artist fix(ui): replaygain for Artist Radio and Top Songs (#4328) 2025-07-08 17:41:14 -03:00
audioplayer feat(plugins): experimental support for plugins (#3998) 2025-06-22 20:45:38 -04:00
common fix(ui): prevent disabled Show in Playlist menu item from triggering actions (#4356) 2025-07-17 11:00:12 -04:00
dataProvider feat(ui): add 'Show in Playlist' context menu (#4139) 2025-05-30 21:26:35 -04:00
dialogs refactor(ui): replace translation key with direct character for remove action 2025-07-12 16:55:21 -04:00
i18n refactor(ui): replace translation key with direct character for remove action 2025-07-12 16:55:21 -04:00
icons build(ui): migrate from CRA/Jest to Vite/Vitest (#3311) 2024-09-28 11:54:36 -04:00
layout fix(ui): keep the NowPlayingPanel badge in sync. 2025-06-29 11:35:10 -04:00
missing fix(ui): update artist link rendering and improve button styles 2025-05-23 17:42:19 -04:00
personal fix(ui): show last.fm api-key missing in a FormHelperText 2024-12-19 16:59:26 -05:00
player build(ui): migrate from CRA/Jest to Vite/Vitest (#3311) 2024-09-28 11:54:36 -04:00
playlist feat(ui): add song Love and Rating functionality to playlist view (#4134) 2025-06-04 20:38:28 -04:00
radio fix(ui): update titles for radios, shares and show pages (#4128) 2025-05-27 09:01:52 -04:00
reducers fix(ui): keep the NowPlayingPanel badge in sync. 2025-06-29 11:35:10 -04:00
share fix(ui): update titles for radios, shares and show pages (#4128) 2025-05-27 09:01:52 -04:00
song feat(ui): implement RecentlyAddedByModTime support for tracks (#4046) (#4279) 2025-06-30 09:14:35 -04:00
store build(ui): migrate from CRA/Jest to Vite/Vitest (#3311) 2024-09-28 11:54:36 -04:00
subsonic feat(plugins): experimental support for plugins (#3998) 2025-06-22 20:45:38 -04:00
themes fix(ui): artist buttons in spotify-ish 2025-06-09 17:56:59 -04:00
transcoding fix(ui): minor icon inconsistencies and "no missing files" translation (#3837) 2025-03-16 19:39:19 -04:00
user fix(ui): update artist link rendering and improve button styles 2025-05-23 17:42:19 -04:00
utils feat(ui): add Play Artist's Top Songs button (#4204) 2025-06-09 19:09:04 -04:00
App.jsx fix(ui): always define config resource. 2025-06-13 00:04:37 -04:00
authProvider.js fix(ui): remove index.html from service worker cache after creating admin user (#3642) 2025-01-12 18:32:02 -05:00
config.js feat(ui): implement new event stream connection logic 2025-06-29 10:18:05 -04:00
consts.js feat(Insights): add anonymous usage data collection (#3543) 2024-12-17 17:10:55 -05:00
eventStream.js fix(ui): keep the NowPlayingPanel badge in sync. 2025-06-29 11:35:10 -04:00
eventStream.test.js test: suppress console.log output in eventStream test 2025-07-10 18:00:37 -03:00
hotkeys.js Change "Go to current song" hotkey. 2022-12-18 20:58:01 -05:00
index.css chore(deps): bump JS dependencies 2025-03-07 19:47:08 -05:00
index.jsx fix(ui): service worker does not load new version of ui (#3402) 2024-10-16 21:39:14 -04:00
routes.jsx build(ui): migrate from CRA/Jest to Vite/Vitest (#3311) 2024-09-28 11:54:36 -04:00
setupTests.js Use the default import path for jest-dom. 2024-01-17 17:07:43 -05:00
sw.js fix(ui): service worker crashing on precacheAndRoute (#3528) 2024-12-08 17:43:34 -05:00
useChangeThemeColor.jsx build(ui): migrate from CRA/Jest to Vite/Vitest (#3311) 2024-09-28 11:54:36 -04:00
vite-env.d.ts build(ui): migrate from CRA/Jest to Vite/Vitest (#3311) 2024-09-28 11:54:36 -04:00