Cold-Air-Networks/mirror-opencl-cts
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove special-case range clamps for the fp16 divide test (#1902)
Some checks failed
Presubmit / Build ubuntu-22.04 gl (push) Failing after 10s
Details
Presubmit / Build ubuntu-22.04 aarch64 debug (push) Failing after 1s
Details
Presubmit / Build ubuntu-22.04 arm (push) Failing after 1s
Details
Presubmit / Check code format (push) Failing after 5m1s
Details
Presubmit / Build macos-latest (push) Has been cancelled
Details
Presubmit / Build windows-latest (push) Has been cancelled
Details

Browse source 
In the fp32 divide test, the range clamps are needed for the "fast
relaxed math" testing, but there is no "fast relaxed math" testing
for fp16.  This means that the range clamps are unnecessary and can
be removed.
This commit is contained in:
Ben Ashbaugh 2024-04-09 09:58:37 -07:00 committed by GitHub
parent 4019a26a5b
commit 11e39f533b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
test_conformance/math_brute_force/binary_operator_half.cpp
View file

@ -143,8 +143,6 @@ cl_int TestHalf(cl_uint job_id, cl_uint thread_id, void *data)
if ((error = clFlush(tinfo->tQueue))) vlog("clFlush failed\n");
}
bool divide = strcmp(name, "divide") == 0;
// Init input array
cl_half *p = (cl_half *)gIn + thread_id * buffer_elements;
cl_half *p2 = (cl_half *)gIn2 + thread_id * buffer_elements;
@ -171,15 +169,6 @@ cl_int TestHalf(cl_uint job_id, cl_uint thread_id, void *data)
y++;
if (y >= specialValuesHalfCount) break;
}
if (divide)
{
cl_half pj = p[idx] & 0x7fff;
cl_half p2j = p2[idx] & 0x7fff;
// Replace values outside [2^-7, 2^7] with QNaN
if (pj < 0x2000 || pj > 0x5800) p[idx] = 0x7e00; // HALF_NAN
if (p2j < 0x2000 || p2j > 0x5800) p2[idx] = 0x7e00;
}
}
}
@ -188,15 +177,6 @@ cl_int TestHalf(cl_uint job_id, cl_uint thread_id, void *data)
{
p[idx] = (cl_half)genrand_int32(d);
p2[idx] = (cl_half)genrand_int32(d);
if (divide)
{
cl_half pj = p[idx] & 0x7fff;
cl_half p2j = p2[idx] & 0x7fff;
// Replace values outside [2^-7, 2^7] with QNaN
if (pj < 0x2000 || pj > 0x5800) p[idx] = 0x7e00; // HALF_NAN
if (p2j < 0x2000 || p2j > 0x5800) p2[idx] = 0x7e00;
}
}
if ((error = clEnqueueWriteBuffer(tinfo->tQueue, tinfo->inBuf, CL_FALSE, 0,
buffer_size, p, 0, NULL, NULL)))