Cold-Air-Networks/mirror-opencl-cts
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mutable_command_info: remove unnecessary Skip function (#2498)
Some checks failed
Presubmit / Build ubuntu-22.04 gl (push) Failing after 1s
Details
Presubmit / Build ubuntu-22.04 aarch64 debug (push) Failing after 1s
Details
Presubmit / Build ubuntu-22.04 android-aarch64 (push) Failing after 1s
Details
Presubmit / Check code format (push) Failing after 5m1s
Details
Presubmit / Build macos-latest (push) Has been cancelled
Details
Presubmit / Build windows-11-arm (push) Has been cancelled
Details
Presubmit / Build windows-latest (push) Has been cancelled
Details

Browse source 
The check implementated by that Skip function is already implemented in
'InfoMutableCommandBufferTest::Skip()'.

Also this is trying to get the extension_version before checking whether
the extension is supported, leading to false negative for device not
supporting the extension.
This commit is contained in:
Romaric Jodin 2025-08-20 20:21:46 +02:00 committed by GitHub
parent 909095f60a
commit 0633af21c1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
test_conformance/extensions/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_info.cpp
View file

@ -116,26 +116,6 @@ struct PropertiesArray : public InfoMutableCommandBufferTest
: InfoMutableCommandBufferTest(device, context, queue)
{}
virtual bool Skip() override
{
Version device_version = get_device_cl_version(device);
if ((device_version >= Version(3, 0))
|| is_extension_available(device, "cl_khr_extended_versioning"))
{
cl_version extension_version = get_extension_version(
device, "cl_khr_command_buffer_mutable_dispatch");
if (extension_version != CL_MAKE_VERSION(0, 9, 3))
{
log_info("cl_khr_command_buffer_mutable_dispatch version 0.9.3 "
"is required to run the test, skipping.\n ");
return true;
}
}
return InfoMutableCommandBufferTest::Skip();
}
cl_int Run() override
{
cl_command_properties_khr props[] = {