67a20745d6
Currently, it is unclear if a test that is skipped is either:
- Unsupported because it will never run (macosx tests should not run on
Windows).
- Skipped because it's supposed to work but does not yet.
`@expectedFailure` is not always an option because a test might be
timing out and waiting 600s for it to fail is not acceptable.
This patch introduces 2 new decorators to differentiate those tests:
- `@requireX` meaning the tests require X to run (e.g `@requireDarwin`).
- `@requireNotX` meaning the tests requires anything but `X` to run (e.g
`@requireNotDarwin`).
In the tests results summary, this introduces a new category: `skipped`
tests:
- `@requireX` -> `UNSUPPORTED`
- `@skipIfX` -> `SKIPPED`
Here is how they can and cannot be stacked:
This will never run:
```py3
@requireDarwin
@requireWindows
def test():
...
```
This will not run on Linux, because `@requireWindows` is not satisfied.
```py3
@requireNotDarwin
@requireWindows
def test():
...
```
For "require Darwin or Windows", you need:
```py3
@requirePlatform(["darwin", "windows"])
def test():
...
```
For "require Darwin on ARM64 or Windows on ARM64", you need:
```py3
@requireARM64
@requirePlatform(["darwin", "windows"])
def test():
...
```
This patch also converts the tests in
`lldb/tests/API/{macosx,linux,windows}` to use these decorators. Patches
to convert the rest of the tests will follow.
95 lines
3.1 KiB
Python
95 lines
3.1 KiB
Python
"""Test that the expedited thread pc values are not re-fetched by lldb."""
|
|
|
|
import subprocess
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
file_index = 0
|
|
|
|
|
|
class TestExpeditedThreadPCs(TestBase):
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
@requireDarwin
|
|
def test_expedited_thread_pcs(self):
|
|
TestBase.setUp(self)
|
|
|
|
global file_index
|
|
++file_index
|
|
logfile = os.path.join(
|
|
self.getBuildDir(),
|
|
"packet-log-" + self.getArchitecture() + "-" + str(file_index) + ".txt",
|
|
)
|
|
self.runCmd("log enable -f %s gdb-remote packets" % (logfile))
|
|
|
|
def cleanup():
|
|
self.runCmd("log disable gdb-remote packets")
|
|
if os.path.exists(logfile):
|
|
os.unlink(logfile)
|
|
|
|
self.addTearDownHook(cleanup)
|
|
|
|
self.source = "main.cpp"
|
|
self.build()
|
|
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
|
|
self,
|
|
"break here",
|
|
lldb.SBFileSpec(self.source, False),
|
|
extra_images=["foo"],
|
|
)
|
|
|
|
# verify that libfoo.dylib hasn't loaded yet
|
|
for m in target.modules:
|
|
self.assertNotEqual(m.GetFileSpec().GetFilename(), "libfoo.dylib")
|
|
|
|
thread.StepInto()
|
|
thread.StepInto()
|
|
|
|
thread.StepInto()
|
|
thread.StepInto()
|
|
thread.StepInto()
|
|
|
|
# verify that libfoo.dylib has loaded
|
|
found_libfoo = False
|
|
for m in target.modules:
|
|
if m.GetFileSpec().GetFilename() == "libfoo.dylib":
|
|
found_libfoo = True
|
|
self.assertTrue(found_libfoo)
|
|
|
|
thread.StepInto()
|
|
thread.StepInto()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
thread.StepOver()
|
|
|
|
process.Kill()
|
|
|
|
# Confirm that we never fetched the pc for any threads during
|
|
# this debug session.
|
|
if os.path.exists(logfile):
|
|
f = open(logfile)
|
|
lines = f.readlines()
|
|
num_errors = 0
|
|
for line in lines:
|
|
arch = self.getArchitecture()
|
|
if arch == "arm64" or arch == "arm64_32":
|
|
# <reg name="pc" regnum="32" offset="256" bitsize="64" group="general" group_id="1" ehframe_regnum="32" dwarf_regnum="32" generic="pc"/>
|
|
# A fetch of $pc on arm64 looks like
|
|
# < 22> send packet: $p20;thread:91698e;#70
|
|
self.assertNotIn("$p20;thread", line)
|
|
else:
|
|
# <reg name="rip" regnum="16" offset="128" bitsize="64" group="general" altname="pc" group_id="1" ehframe_regnum="16" dwarf_regnum="16" generic="pc"/>
|
|
# A fetch of $pc on x86_64 looks like
|
|
# < 22> send packet: $p10;thread:91889c;#6f
|
|
self.assertNotIn("$p10;thread", line)
|
|
|
|
f.close()
|