67a20745d6
Currently, it is unclear if a test that is skipped is either:
- Unsupported because it will never run (macosx tests should not run on
Windows).
- Skipped because it's supposed to work but does not yet.
`@expectedFailure` is not always an option because a test might be
timing out and waiting 600s for it to fail is not acceptable.
This patch introduces 2 new decorators to differentiate those tests:
- `@requireX` meaning the tests require X to run (e.g `@requireDarwin`).
- `@requireNotX` meaning the tests requires anything but `X` to run (e.g
`@requireNotDarwin`).
In the tests results summary, this introduces a new category: `skipped`
tests:
- `@requireX` -> `UNSUPPORTED`
- `@skipIfX` -> `SKIPPED`
Here is how they can and cannot be stacked:
This will never run:
```py3
@requireDarwin
@requireWindows
def test():
...
```
This will not run on Linux, because `@requireWindows` is not satisfied.
```py3
@requireNotDarwin
@requireWindows
def test():
...
```
For "require Darwin or Windows", you need:
```py3
@requirePlatform(["darwin", "windows"])
def test():
...
```
For "require Darwin on ARM64 or Windows on ARM64", you need:
```py3
@requireARM64
@requirePlatform(["darwin", "windows"])
def test():
...
```
This patch also converts the tests in
`lldb/tests/API/{macosx,linux,windows}` to use these decorators. Patches
to convert the rest of the tests will follow.
36 lines
1.3 KiB
Python
36 lines
1.3 KiB
Python
import time
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class DenyAttachTestCase(TestBase):
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
@requireDarwin
|
|
@skipIfDarwinEmbedded # PT_DENY_ATTACH attach behavior differs on ios/tvos/etc
|
|
@skipIfAsan # Attach tests time out inconsistently under asan.
|
|
def test_attach_to_deny_attach_process(self):
|
|
"""Attaching to a PT_DENY_ATTACH process reports an error, not a crash."""
|
|
self.build()
|
|
exe = self.getBuildArtifact("a.out")
|
|
|
|
# Use a file as a synchronization point between test and inferior: the
|
|
# inferior writes its pid only after it has called PT_DENY_ATTACH.
|
|
pid_file_path = lldbutil.append_to_process_working_directory(
|
|
self, "pid_file_%d" % (int(time.time()))
|
|
)
|
|
self.addTearDownHook(
|
|
lambda: self.run_platform_command("rm %s" % (pid_file_path))
|
|
)
|
|
|
|
popen = self.spawnSubprocess(exe, [pid_file_path])
|
|
pid = lldbutil.wait_for_file_on_target(self, pid_file_path)
|
|
|
|
self.expect(
|
|
"process attach -p " + pid,
|
|
startstr="error: attach failed:",
|
|
substrs=["PT_DENY_ATTACH"],
|
|
error=True,
|
|
)
|