Fixes #211135. `openmp/module/CMakeLists.txt:29` gates the GPU-only Fortran compile options on `"^amdgcn|^nvptx"`, while `openmp/CMakeLists.txt:176-177` selects host-vs-device layout for the same build using `"^amdgpu|^amdgcn|^nvptx|^spirv64"` against both `LLVM_DEFAULT_TARGET_TRIPLE` and `CMAKE_CXX_COMPILER_TARGET`. All four offload cache files use the triple `amdgpu-amd-amdhsa`, which `^amdgcn` does not match, so `-nogpulib -flto` are silently not applied to `libomp-mod` in the recommended AMDGPU offload configurations. Compute the test once as `LIBOMP_TARGET_IS_GPU` in `openmp/CMakeLists.txt` and use it at both sites, rather than duplicating a widened regex. The conditions differ, not just the patterns: copying the regex alone would leave a build that sets `CMAKE_CXX_COMPILER_TARGET` without `LLVM_DEFAULT_TARGET_TRIPLE` still taking the device path in `openmp/` while `libomp-mod` misses the flags. `libomp-mod` compiles Fortran, so `CMAKE_Fortran_COMPILER_TARGET` is also consulted; neither site did before. Evaluated with CMake's regex engine: | triple | before | after | |---|---|---| | `amdgpu-amd-amdhsa` | 0 | 1 | | `amdgcn-amd-amdhsa` | 1 | 1 | | `nvptx64-nvidia-cuda` | 1 | 1 | | `spirv64-amd-amdhsa` | 0 | 1 | | `x86_64-unknown-linux-gnu` | 0 | 0 | `^spirv64` only brings `module/` in line with `openmp/CMakeLists.txt:176`, which already routes spirv64 to `device/`. Host builds are unaffected. Roughly five other sites carry the same `amdgcn`-only pattern (`offload/CMakeLists.txt:30`, `flang-rt/CMakeLists.txt:126`, `flang-rt/lib/runtime/CMakeLists.txt:317`, `flang-rt/cmake/modules/AddFlangRT.cmake:298`, `cmake/Modules/GetToolchainDirs.cmake:118`) and are left for a follow-up. No test: configure-time logic, no test mechanism exists in `openmp/`. This affects performance-critical applications on large AMD GPU supercomputers, including [MFC](https://github.com/MFlowCode/MFC). All numbers above come from the validated reproducers included with this report and are independently reproducible; they stand on their own. This was found and root-caused with the assistance of AI tools.
221 lines
8.4 KiB
CMake
221 lines
8.4 KiB
CMake
cmake_minimum_required(VERSION 3.20.0)
|
|
if("${CMAKE_VERSION}" VERSION_LESS "3.31.0")
|
|
message(WARNING
|
|
"Your CMake version is ${CMAKE_VERSION}. Starting with LLVM 24, the "
|
|
"minimum version of CMake required to build LLVM will become 3.31.0, and "
|
|
"using an older CMake will become an error. Please upgrade your CMake to "
|
|
"at least 3.31.0 now to avoid issues in the future.")
|
|
endif()
|
|
|
|
set(LLVM_SUBPROJECT_TITLE "OpenMP")
|
|
|
|
set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
|
|
include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
|
|
NO_POLICY_SCOPE)
|
|
|
|
# Add path for custom modules
|
|
list(INSERT CMAKE_MODULE_PATH 0
|
|
"${CMAKE_CURRENT_SOURCE_DIR}/cmake"
|
|
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
|
|
"${LLVM_COMMON_CMAKE_UTILS}/Modules"
|
|
)
|
|
|
|
if (OPENMP_STANDALONE_BUILD OR "${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
|
|
message(FATAL_ERROR [[The legacy standalone build mode has been removed. Please change
|
|
cmake <llvm-project>/openmp
|
|
to
|
|
cmake <llvm-project>/runtimes -DLLVM_ENABLE_RUNTIMES=openmp
|
|
For more details on building the LLVM OpenMP libraries, see https://openmp.llvm.org/Building.html]])
|
|
endif()
|
|
|
|
# Must go below project(..)
|
|
include(GNUInstallDirs)
|
|
|
|
# Usually <llvm-project>/runtimes/CMakeLists.txt sets LLVM_TREE_AVAILABLE and
|
|
# we assume it is not available otherwise. The exception is that we are in an
|
|
# LLVM_ENABLE_PROJECTS=openmp build, the LLVM tree is actually available.
|
|
# Note that this build mode has been deprecated.
|
|
# See https://github.com/llvm/llvm-project/issues/124014
|
|
if (NOT LLVM_RUNTIMES_BUILD AND "openmp" IN_LIST LLVM_ENABLE_PROJECTS)
|
|
set(LLVM_TREE_AVAILABLE True)
|
|
endif ()
|
|
|
|
set(OPENMP_ENABLE_WERROR ${LLVM_ENABLE_WERROR})
|
|
|
|
# When building in tree we install the runtime according to the LLVM settings.
|
|
# TODO: Use common runtimes infrastructure for output and install paths
|
|
if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
|
|
set(OPENMP_TARGET_SUBDIR "${LLVM_DEFAULT_TARGET_TRIPLE}")
|
|
if(OPENMP_LIBDIR_SUBDIR)
|
|
string(APPEND OPENMP_TARGET_SUBDIR "/${OPENMP_LIBDIR_SUBDIR}")
|
|
endif()
|
|
cmake_path(NORMAL_PATH OPENMP_TARGET_SUBDIR)
|
|
set(OPENMP_INSTALL_LIBDIR "lib${LLVM_LIBDIR_SUFFIX}/${OPENMP_TARGET_SUBDIR}" CACHE STRING
|
|
"Path where built openmp libraries should be installed.")
|
|
else()
|
|
set(OPENMP_INSTALL_LIBDIR "lib${LLVM_LIBDIR_SUFFIX}" CACHE STRING
|
|
"Path where built OpenMP libraries should be installed.")
|
|
endif()
|
|
|
|
set(OPENMP_TEST_C_COMPILER_default "${LLVM_TOOLS_BINARY_DIR}/clang${CMAKE_EXECUTABLE_SUFFIX}")
|
|
set(OPENMP_TEST_CXX_COMPILER_default "${LLVM_TOOLS_BINARY_DIR}/clang++${CMAKE_EXECUTABLE_SUFFIX}")
|
|
set(OPENMP_TEST_Fortran_COMPILER_default "${LLVM_TOOLS_BINARY_DIR}/flang${CMAKE_EXECUTABLE_SUFFIX}")
|
|
if (NOT TARGET "clang")
|
|
set(OPENMP_TEST_C_COMPILER_default "${CMAKE_C_COMPILER}")
|
|
set(OPENMP_TEST_CXX_COMPILER_default "${CMAKE_CXX_COMPILER}")
|
|
endif()
|
|
if (NOT TARGET "flang")
|
|
if (CMAKE_Fortran_COMPILER)
|
|
set(OPENMP_TEST_Fortran_COMPILER_default "${CMAKE_Fortran_COMPILER}")
|
|
else()
|
|
unset(OPENMP_TEST_Fortran_COMPILER_default)
|
|
endif()
|
|
endif()
|
|
set(OPENMP_TEST_C_COMPILER "${OPENMP_TEST_C_COMPILER_default}" CACHE STRING
|
|
"C compiler to use for testing OpenMP runtime libraries.")
|
|
set(OPENMP_TEST_CXX_COMPILER "${OPENMP_TEST_CXX_COMPILER_default}" CACHE STRING
|
|
"C++ compiler to use for testing OpenMP runtime libraries.")
|
|
set(OPENMP_TEST_Fortran_COMPILER "${OPENMP_TEST_Fortran_COMPILER_default}" CACHE STRING
|
|
"Fortran compiler to use for testing OpenMP runtime libraries.")
|
|
|
|
# Set fortran test compiler if flang is found
|
|
if (EXISTS "${OPENMP_TEST_Fortran_COMPILER}")
|
|
message("Using local flang build at ${OPENMP_TEST_Fortran_COMPILER}")
|
|
else()
|
|
unset(OPENMP_TEST_Fortran_COMPILER)
|
|
endif()
|
|
|
|
# If not standalone, set CMAKE_CXX_STANDARD but don't set the global cache value,
|
|
# only set it locally for OpenMP.
|
|
set(CMAKE_CXX_STANDARD 17)
|
|
set(CMAKE_CXX_STANDARD_REQUIRED NO)
|
|
set(CMAKE_CXX_EXTENSIONS NO)
|
|
|
|
# Check and set up common compiler flags.
|
|
include(config-ix)
|
|
include(HandleOpenMPOptions)
|
|
include(LibompUtils)
|
|
include(LibompHandleFlags)
|
|
|
|
|
|
# Set libomp version
|
|
set(LIBOMP_VERSION_MAJOR 5)
|
|
set(LIBOMP_VERSION_MINOR 0)
|
|
|
|
# Set the OpenMP Year and Month associated with version
|
|
set(LIBOMP_OMP_YEAR_MONTH 201611)
|
|
|
|
# Get the build number from kmp_version.cpp
|
|
libomp_get_build_number("${CMAKE_CURRENT_SOURCE_DIR}/runtime" LIBOMP_VERSION_BUILD)
|
|
math(EXPR LIBOMP_VERSION_BUILD_YEAR "${LIBOMP_VERSION_BUILD}/10000")
|
|
math(EXPR LIBOMP_VERSION_BUILD_MONTH_DAY "${LIBOMP_VERSION_BUILD}%10000")
|
|
|
|
# Currently don't record any timestamps
|
|
set(LIBOMP_BUILD_DATE "No_Timestamp")
|
|
|
|
|
|
set(LIBOMP_FORTRAN_MODULES "${RUNTIMES_FORTRAN_MODULES}" CACHE BOOL
|
|
"Create Fortran module files? (requires fortran compiler)")
|
|
|
|
option(LIBOMP_FORTRAN_MODULES_ONLY
|
|
"Build only Fortran modules without libomp runtime library" OFF)
|
|
if(LIBOMP_FORTRAN_MODULES_ONLY)
|
|
set(LIBOMP_FORTRAN_MODULES TRUE)
|
|
endif()
|
|
|
|
# Set up testing infrastructure.
|
|
include(OpenMPTesting)
|
|
|
|
set(OPENMP_TEST_FLAGS "" CACHE STRING
|
|
"Extra compiler flags to send to the test compiler.")
|
|
set(OPENMP_TEST_OPENMP_FLAGS ${OPENMP_TEST_COMPILER_OPENMP_FLAGS} CACHE STRING
|
|
"OpenMP compiler flag to use for testing OpenMP runtime libraries.")
|
|
set(OPENMP_TEST_Fortran_FLAGS "${CMAKE_Fortran_FLAGS}" CACHE STRING
|
|
"Additional compiler flags to use for testing Fortran programs (e.g. additional module search paths via -fintrinsic-modules-path )")
|
|
|
|
set(ENABLE_LIBOMPTARGET ON)
|
|
# Currently libomptarget cannot be compiled on Windows or MacOS X.
|
|
# Since the device plugins are only supported on Linux anyway,
|
|
# there is no point in trying to compile libomptarget on other OSes.
|
|
# 32-bit systems are not supported either.
|
|
if (APPLE OR WIN32 OR WASM OR NOT "cxx_std_17" IN_LIST CMAKE_CXX_COMPILE_FEATURES
|
|
OR NOT CMAKE_SIZEOF_VOID_P EQUAL 8 OR "${CMAKE_SYSTEM_NAME}" MATCHES "AIX")
|
|
set(ENABLE_LIBOMPTARGET OFF)
|
|
endif()
|
|
|
|
option(OPENMP_ENABLE_LIBOMPTARGET "Enable building libomptarget for offloading."
|
|
${ENABLE_LIBOMPTARGET})
|
|
option(OPENMP_ENABLE_LIBOMP_PROFILING "Enable time profiling for libomp." OFF)
|
|
|
|
# Header install location
|
|
if(NOT LLVM_TREE_AVAILABLE)
|
|
set(LIBOMP_HEADERS_INSTALL_PATH "${CMAKE_INSTALL_INCLUDEDIR}")
|
|
else()
|
|
include(GetClangResourceDir)
|
|
get_clang_resource_dir(LIBOMP_HEADERS_INSTALL_PATH SUBDIR include)
|
|
endif()
|
|
|
|
# Meta-target for building OpenMP runtime artifacts (libraries, device RTL, tools).
|
|
# Subdirectories call openmp_register_meta_dep() for each target they add.
|
|
add_custom_target(openmp ALL
|
|
COMMENT "OpenMP meta-target. Use 'ninja openmp' to build all OpenMP runtime targets."
|
|
)
|
|
|
|
add_custom_target(install-openmp
|
|
COMMAND "${CMAKE_COMMAND}" --install "${CMAKE_BINARY_DIR}" --component openmp)
|
|
add_custom_target(install-openmp-stripped
|
|
COMMAND "${CMAKE_COMMAND}" --install "${CMAKE_BINARY_DIR}" --component openmp --strip)
|
|
add_dependencies(install-openmp openmp)
|
|
add_dependencies(install-openmp-stripped openmp)
|
|
|
|
# Whether this build targets a GPU. "amdgcn" is the legacy spelling of "amdgpu";
|
|
# both reach here, and the offload cache files use "amdgpu-amd-amdhsa".
|
|
set(LIBOMP_GPU_TRIPLE_REGEX "^amdgpu|^amdgcn|^nvptx|^spirv64")
|
|
if("${LLVM_DEFAULT_TARGET_TRIPLE}" MATCHES "${LIBOMP_GPU_TRIPLE_REGEX}" OR
|
|
"${CMAKE_CXX_COMPILER_TARGET}" MATCHES "${LIBOMP_GPU_TRIPLE_REGEX}" OR
|
|
"${CMAKE_Fortran_COMPILER_TARGET}" MATCHES "${LIBOMP_GPU_TRIPLE_REGEX}")
|
|
set(LIBOMP_TARGET_IS_GPU TRUE)
|
|
else()
|
|
set(LIBOMP_TARGET_IS_GPU FALSE)
|
|
endif()
|
|
|
|
if(LIBOMP_FORTRAN_MODULES)
|
|
add_subdirectory(module)
|
|
endif()
|
|
|
|
if(LIBOMP_TARGET_IS_GPU)
|
|
add_subdirectory(device)
|
|
else()
|
|
# Build host runtime library, after LIBOMPTARGET variables are set since they
|
|
# are needed to enable time profiling support in the OpenMP runtime.
|
|
if(NOT LIBOMP_FORTRAN_MODULES_ONLY)
|
|
add_subdirectory(runtime)
|
|
endif()
|
|
|
|
set(ENABLE_OMPT_TOOLS ON)
|
|
# Currently tools are not tested well on Windows or MacOS X.
|
|
if (APPLE OR WIN32)
|
|
set(ENABLE_OMPT_TOOLS OFF)
|
|
endif()
|
|
|
|
option(OPENMP_ENABLE_OMPT_TOOLS "Enable building ompt based tools for OpenMP."
|
|
${ENABLE_OMPT_TOOLS})
|
|
if (OPENMP_ENABLE_OMPT_TOOLS)
|
|
add_subdirectory(tools)
|
|
endif()
|
|
|
|
# Propagate OMPT support to offload
|
|
set(LIBOMP_HAVE_OMPT_SUPPORT ${LIBOMP_HAVE_OMPT_SUPPORT} PARENT_SCOPE)
|
|
set(LIBOMP_OMP_TOOLS_INCLUDE_DIR ${LIBOMP_OMP_TOOLS_INCLUDE_DIR} PARENT_SCOPE)
|
|
|
|
option(OPENMP_MSVC_NAME_SCHEME "Build dll with MSVC naming scheme." OFF)
|
|
|
|
# Build libompd.so
|
|
add_subdirectory(libompd)
|
|
|
|
# Build documentation
|
|
add_subdirectory(docs)
|
|
endif()
|
|
|
|
# Now that we have seen all testsuites, create the check-openmp target.
|
|
construct_check_openmp_target()
|