43e4757d85
Ties the semantic checks for overwriting a asynchronous or volatile value with a copy-out operation to the function `evaluate::MayNeedCopy(..., /*forCopyOut=*/false)`. This should make the checks more accurate and consistent with the lowering. The PR also adds a default check that looks for the undesired behavior directly, in case extension later modify what is possible. A couple portability warnings are added where other compilers are over restrictive. Closes https://github.com/llvm/llvm-project/issues/137369 ``` $ build/bin/flang -c ~/work/llvm-test-suite/Fortran/gfortran/regression/volatile8.f90 -pedantic /home/akuhlenschmi/work/llvm-test-suite/Fortran/gfortran/regression/volatile8.f90:21:16: warning: The array section 'a(1_8:5_8:2_8)' should not be associated with dummy argument 'dummy8=' with VOLATILE attribute, unless the dummy is assumed-shape or assumed-rank [-Wvolatile-or-asynchronous-temporary] call sub8 (a(1:5:2)) ! { dg-error "Array-section actual argument" } ^^^^^^^^ /home/akuhlenschmi/work/llvm-test-suite/Fortran/gfortran/regression/volatile8.f90:37:16: portability: The actual argument 's9dummy' should not be associated with dummy argument 'dummy9=' with VOLATILE attribute, because a temporary copy is required during the call [-Wportability] call sub9 (s9dummy) ! { dg-error "Assumed-shape actual argument" } ^^^^^^^ /home/akuhlenschmi/work/llvm-test-suite/Fortran/gfortran/regression/volatile8.f90:55:17: portability: The actual argument 'a' should not be associated with dummy argument 'dummy10=' with VOLATILE attribute, because a temporary copy is required during the call [-Wportability] call sub10 (a) ! { dg-error "Pointer-array actual argument" } ^ ```
46 lines
2 KiB
Fortran
46 lines
2 KiB
Fortran
! RUN: %python %S/test_errors.py %s %flang_fc1 -pedantic -Werror
|
|
program call45
|
|
integer, target :: v(100) = [(i, i=1, 100)]
|
|
integer, pointer :: p(:) => v
|
|
!ERROR: Actual argument associated with VOLATILE dummy argument 'v=' is not definable [-Wundefinable-asynchronous-or-volatile-actual]
|
|
!BECAUSE: Variable 'v([INTEGER(8)::1_8,2_8,2_8,3_8,3_8,3_8,4_8,4_8,4_8,4_8])' has a vector subscript
|
|
call sub(v([1,2,2,3,3,3,4,4,4,4]))
|
|
!PORTABILITY: The array section 'v(21_8:30_8:1_8)' should not be associated with dummy argument 'v=' with VOLATILE attribute, unless the dummy is assumed-shape or assumed-rank [-Wportability]
|
|
call sub(v(21:30))
|
|
!WARNING: The array section 'v(21_8:40_8:2_8)' should not be associated with dummy argument 'v=' with VOLATILE attribute, unless the dummy is assumed-shape or assumed-rank [-Wvolatile-or-asynchronous-temporary]
|
|
call sub(v(21:40:2))
|
|
call sub2(v(21:40:2))
|
|
call sub4(p)
|
|
call sub5(p)
|
|
print *, v
|
|
contains
|
|
subroutine sub(v)
|
|
integer, volatile :: v(10)
|
|
v = 0
|
|
end subroutine sub
|
|
subroutine sub1(v)
|
|
integer, volatile :: v(:)
|
|
v = 0
|
|
end subroutine sub1
|
|
subroutine sub2(v)
|
|
integer :: v(:)
|
|
!PORTABILITY: The actual argument 'v' should not be associated with dummy argument 'v=' with VOLATILE attribute, because a temporary copy is required during the call [-Wportability]
|
|
call sub(v)
|
|
call sub1(v)
|
|
end subroutine sub2
|
|
subroutine sub3(v)
|
|
integer, pointer :: v(:)
|
|
v = 0
|
|
end subroutine sub3
|
|
subroutine sub4(v)
|
|
integer, pointer :: v(:)
|
|
!PORTABILITY: The actual argument 'v' should not be associated with dummy argument 'v=' with VOLATILE attribute, because a temporary copy is required during the call [-Wportability]
|
|
call sub(v)
|
|
call sub1(v)
|
|
call sub3(v)
|
|
call sub5(v)
|
|
end subroutine sub4
|
|
subroutine sub5(v)
|
|
integer, pointer, volatile :: v(:)
|
|
end subroutine sub5
|
|
end program call45
|