Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[llubi] Fix the number of words to reserve in Context::toBytes (#200651)

Browse source 
The bits should be divided by 64 instead of 8 :(
This commit is contained in:
Yingwei Zheng 2026-05-31 20:06:46 +08:00 committed by GitHub
parent b48743be09
commit fe87c971bf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
llvm/tools/llubi/lib/Context.cpp
View file

@ -138,10 +138,11 @@ AnyValue Context::fromBytes(ConstBytesView Bytes, Type *Ty,
NewOffsetInBits = alignTo(NewOffsetInBits, 8);
bool NeedsPadding = NewOffsetInBits != OffsetInBits + NumBits;
uint32_t NumBitsToExtract = NewOffsetInBits - OffsetInBits;
uint32_t NumWords = divideCeil(NumBitsToExtract, 8);
SmallVector<uint64_t> RawBits(NumWords);
uint32_t NumWords = APInt::getNumWords(NumBitsToExtract);
constexpr uint32_t WordBits = APInt::APINT_BITS_PER_WORD;
SmallVector<APInt::WordType> RawBits(NumWords);
bool IsTagValid = Ty->isPointerTy();
SmallVector<uint64_t> RawTagBits;
SmallVector<APInt::WordType> RawTagBits;
if (Ty->isPointerTy())
RawTagBits.resize(NumWords);
for (uint32_t I = 0; I < NumBitsToExtract; I += 8) {
@ -183,12 +184,13 @@ AnyValue Context::fromBytes(ConstBytesView Bytes, Type *Ty,
uint8_t ActualBits = ((LogicalByte.Value & LogicalByte.ConcreteMask) |
(RandomBits & ~LogicalByte.ConcreteMask)) &
Mask;
RawBits[I / 64] |= static_cast<APInt::WordType>(ActualBits) << (I % 64);
RawBits[I / WordBits] |= static_cast<APInt::WordType>(ActualBits)
<< (I % WordBits);
if (IsTagValid) {
if ((LogicalByte.TagMask & LogicalByte.ConcreteMask & Mask) == Mask) {
uint8_t ActualTagBits = LogicalByte.TagValue & Mask;
RawTagBits[I / 64] |= static_cast<APInt::WordType>(ActualTagBits)
<< (I % 64);
RawTagBits[I / WordBits] |= static_cast<APInt::WordType>(ActualTagBits)
<< (I % WordBits);
} else {
IsTagValid = false;
}