Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[flang] Check for errors when analyzing array constructors (#173092)

Browse source 
Errors in array constructor values result in the array having
less elements than it should, which can cause other errors that
will confuse the user. Avoid this by not returning an expression
on errors.

Fixes #127425
This commit is contained in:
Leandro Lupori 2026-01-08 11:33:21 -03:00 committed by GitHub
parent 9e78d8a4fb
commit fa53d9285a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
flang/lib/Semantics/expression.cpp
View file

@ -2075,11 +2075,15 @@ MaybeExpr ArrayConstructorContext::ToExpr() {
MaybeExpr ExpressionAnalyzer::Analyze(const parser::ArrayConstructor &array) {
const parser::AcSpec &acSpec{array.v};
bool hadAnyFatalError{context_.AnyFatalError()};
ArrayConstructorContext acContext{
*this, AnalyzeTypeSpec(acSpec.type, GetFoldingContext())};
for (const parser::AcValue &value : acSpec.values) {
acContext.Add(value);
}
if (!hadAnyFatalError && context_.AnyFatalError()) {
return std::nullopt;
}
return acContext.ToExpr();
}

10
flang/test/Semantics/bug127425.f90 Normal file
View file

@ -0,0 +1,10 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
program main
implicit none
integer :: ja, jb, j3, j4, j5
pointer (j1,ja)
pointer (j2,jb)
!ERROR: Values in array constructor must have the same declared type when no explicit type appears
if (any((/j1,j2,j3,j4,j5/)/=(/1,2,3,4,5/))) print *,'fail'
end program main