Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[mlir][Python] don't build libnanobind if module only has "pure" sources (#175090)

Browse source 
Like IREE's
[`IREECompilerBuildPythonModules`](47fe908217/compiler/bindings/python/CMakeLists.txt (L300-L305)).
Note, setting `MLIR_BINDINGS_PYTHON_NB_DOMAIN` on
`add_mlir_python_modules` explicitly would also workaround issues
related to this (and is generally recommended for projects building
multiple bindings packages).

---------

Co-authored-by: Rahul Kayaith <rkayaith@amd.com>
This commit is contained in:
Maksim Levental 2026-01-12 12:09:16 -05:00 committed by GitHub
parent 7676471c70
commit effa813844
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
mlir/cmake/modules/AddMLIRPython.cmake
View file

@ -393,13 +393,28 @@ function(add_mlir_python_modules name)
set(ARG_MLIR_BINDINGS_PYTHON_NB_DOMAIN "mlir")
endif()
# Collect up all the transitive extension targets.
_flatten_mlir_python_targets(_flat_targets ${ARG_DECLARED_SOURCES})
# Modules with only pure python sources shouldn't build libnanobind.
set(_needs_build_nanobind_lib OFF)
foreach(sources_target ${_flat_targets})
get_target_property(_source_type ${sources_target} mlir_python_SOURCES_TYPE)
if((_source_type STREQUAL "support") OR (_source_type STREQUAL "extension"))
set(_needs_build_nanobind_lib ON)
break()
endif()
endforeach()
# This call sets NB_LIBRARY_TARGET_NAME.
build_nanobind_lib(
INSTALL_COMPONENT ${name}
INSTALL_DESTINATION "${ARG_INSTALL_PREFIX}/_mlir_libs"
OUTPUT_DIRECTORY "${ARG_ROOT_PREFIX}/_mlir_libs"
MLIR_BINDINGS_PYTHON_NB_DOMAIN ${ARG_MLIR_BINDINGS_PYTHON_NB_DOMAIN}
)
if(_needs_build_nanobind_lib)
build_nanobind_lib(
INSTALL_COMPONENT ${name}
INSTALL_DESTINATION "${ARG_INSTALL_PREFIX}/_mlir_libs"
OUTPUT_DIRECTORY "${ARG_ROOT_PREFIX}/_mlir_libs"
MLIR_BINDINGS_PYTHON_NB_DOMAIN ${ARG_MLIR_BINDINGS_PYTHON_NB_DOMAIN}
)
endif()
# Helper to process an individual target.
function(_process_target modules_target sources_target support_libs)
@ -442,7 +457,6 @@ function(add_mlir_python_modules name)
# Build the modules target.
add_custom_target(${name} ALL)
_flatten_mlir_python_targets(_flat_targets ${ARG_DECLARED_SOURCES})
# Build all support libs first.
set(_mlir_python_support_libs)