Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[OpenACC] Accept funcs with acc.specialized_routine in acc::isValidSymbolUse (#211111)

Browse source 
`ACCRoutineLowering` generates device side specialized version of
routines that have the `acc.specialized_routine` attribute. Those are
expected to be offloaded and therefore are valid symbol uses.

Assisted-by: Claude Code
This commit is contained in:
Moazin K. 2026-07-21 22:22:40 -07:00 committed by GitHub
parent 06bbd269cb
commit e8b66ff170
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 38 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
mlir/lib/Dialect/OpenACC/Utils/OpenACCUtils.cpp
View file

@ -220,9 +220,10 @@ bool mlir::acc::isValidSymbolUse(mlir::Operation *user,
// Check if the defining op is a function
if (auto func =
mlir::dyn_cast_if_present<mlir::FunctionOpInterface>(definingOp)) {
// If this symbol is actually an acc routine - then it is expected for it
// to be offloaded - therefore it is valid.
if (func->hasAttr(mlir::acc::getRoutineInfoAttrName()))
// If this symbol is actually an acc routine or a specialized acc routine -
// then it is expected for it to be offloaded - therefore it is valid.
if (func->hasAttr(mlir::acc::getRoutineInfoAttrName()) ||
func->hasAttr(mlir::acc::getSpecializedRoutineAttrName()))
return true;
// If this symbol is a call to an LLVM intrinsic, then it is likely valid.

34
mlir/test/Dialect/OpenACC/offload-target-verifier.mlir
View file

@ -245,3 +245,37 @@ func.func @test_f64_scalar() {
}
return
}
// -----
// Test call to a function marked as an acc routine - should pass
acc.routine @acc_routine_0 func(@routine_callee) gang
func.func @routine_callee() attributes {acc.routine_info = #acc.routine_info<[@acc_routine_0]>} {
return
}
func.func @test_acc_routine() {
// expected-remark @below {{passed validity check}}
acc.parallel {
func.call @routine_callee() : () -> ()
acc.yield
}
return
}
// -----
// Test call to a function marked as a specialized acc routine - should pass
acc.routine @acc_routine_1 func(@specialized_callee) gang
func.func @specialized_callee() attributes {acc.specialized_routine = #acc.specialized_routine<@acc_routine_1, <gang_dim1>, "specialized_callee">} {
return
}
func.func @test_acc_specialized_routine() {
// expected-remark @below {{passed validity check}}
acc.parallel {
func.call @specialized_callee() : () -> ()
acc.yield
}
return
}