Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[OFFLOAD][L0] Fix PatternSize assert in L0QueueTy::memoryFill (#210867)

Browse source 
The message was the opposite of the assert condition.

In addition, when PatternSize == Size the caller wants to fill the
region with exactly one copy of the pattern, which is a valid operation.

The issue was found by AI.

Also check `Size % PatternSize == 0` per L0 spec.
This commit is contained in:
Wenju He 2026-07-21 02:20:16 -07:00 committed by GitHub
parent dce3dc8049
commit bcde1af59d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
offload/plugins-nextgen/level_zero/src/L0Queue.cpp
View file

@ -65,12 +65,12 @@ Error L0QueueTy::dispatchLaunchKernel(ze_kernel_handle_t Kernel,
Error L0QueueTy::memoryFill(void *Ptr, const void *Pattern, size_t PatternSize,
size_t Size) {
assert(PatternSize < Size && "PatternSize < Size is unsupported");
assert(PatternSize <= Size && "PatternSize > Size is unsupported");
if (Size == 0 || PatternSize == 0)
return Plugin::success();
if (llvm::isPowerOf2_64(PatternSize) &&
if (llvm::isPowerOf2_64(PatternSize) && (Size % PatternSize == 0) &&
PatternSize <= Device.getMaxMemFillPatternSize()) {
// Native L0 memory fill is possible directly.
return memoryFillImpl(Ptr, Pattern, PatternSize, Size);