Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

clang: Emit "float-abi" module flag (#212985)

Browse source 
Emit the new module flag if it differs from the triple's
default.

Co-authored-by: Claude (Claude-Opus-4.8) <noreply@anthropic.com>
This commit is contained in:
Matt Arsenault 2026-07-31 19:07:04 +02:00 committed by GitHub
parent 7fd627a749
commit bbbc3e4cc9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 47 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
clang/lib/CodeGen/CodeGenModule.cpp
View file

@ -1380,6 +1380,21 @@ void CodeGenModule::Release() {
getModule().addModuleFlag(llvm::Module::Error, "wchar_size",
static_cast<uint32_t>(WCharWidth));
// Record the floating-point ABI as a module flag when it differs from the
// target default. softfp collapses to soft.
llvm::FloatABI::ABIType FloatABI =
llvm::StringSwitch<llvm::FloatABI::ABIType>(CodeGenOpts.FloatABI)
.Cases({"soft", "softfp"}, llvm::FloatABI::Soft)
.Case("hard", llvm::FloatABI::Hard)
.Default(llvm::FloatABI::Default);
if (FloatABI != llvm::FloatABI::Default &&
FloatABI != getTriple().getDefaultFloatABI()) {
getModule().addModuleFlag(
llvm::Module::Error, "float-abi",
llvm::MDString::get(getLLVMContext(),
llvm::FloatABI::getABITypeName(FloatABI)));
}
if (getTriple().isOSzOS()) {
getModule().addModuleFlag(llvm::Module::Warning,
"zos_product_major_version",

32
clang/test/CodeGen/arm-float-abi-flag.c Normal file
View file

@ -0,0 +1,32 @@
// Check that clang emits the "float-abi" module flag only when the resolved
// floating-point ABI differs from the target default.
// Default (soft) ABI on a soft-default triple: no flag.
// RUN: %clang_cc1 -triple arm-none-none-eabi -emit-llvm -o - %s \
// RUN: | FileCheck %s --check-prefix=NONE
// Explicit hard on a soft-default triple: flag emitted.
// RUN: %clang_cc1 -triple arm-none-none-eabi -mfloat-abi hard -emit-llvm -o - %s \
// RUN: | FileCheck %s --check-prefix=HARD
// Explicit soft on a soft-default triple: matches default, no flag.
// RUN: %clang_cc1 -triple arm-none-none-eabi -mfloat-abi soft -emit-llvm -o - %s \
// RUN: | FileCheck %s --check-prefix=NONE
// Default (hard) ABI on a hard-default triple: no flag.
// RUN: %clang_cc1 -triple arm-none-none-eabihf -emit-llvm -o - %s \
// RUN: | FileCheck %s --check-prefix=NONE
// Explicit soft on a hard-default triple: flag emitted.
// RUN: %clang_cc1 -triple arm-none-none-eabihf -mfloat-abi soft -emit-llvm -o - %s \
// RUN: | FileCheck %s --check-prefix=SOFT
// softfp collapses to soft: on a hard-default triple, flag emitted as soft.
// RUN: %clang_cc1 -triple arm-none-none-eabihf -mfloat-abi softfp -emit-llvm -o - %s \
// RUN: | FileCheck %s --check-prefix=SOFT
void f(void) {}
// NONE-NOT: !"float-abi"
// HARD: !{i32 1, !"float-abi", !"hard"}
// SOFT: !{i32 1, !"float-abi", !"soft"}