From b1a35022e0d7abee1b3baffa8907feca19a7daa8 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Tue, 14 Jul 2026 18:12:11 -0700 Subject: [PATCH] [BOLT] Remove ability to use external shell The external shell is getting removed soon, so remove the ability to force the use of it within BOLT. Reviewers: aaupov, petrhosek, maksfb, yozhu, paschalis-mpeis, yavtuk, ilovepi, rafaelauler, ayermolo Pull Request: https://github.com/llvm/llvm-project/pull/209567 --- bolt/test/lit.cfg.py | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/bolt/test/lit.cfg.py b/bolt/test/lit.cfg.py index a3a49444156b..218ea24867eb 100644 --- a/bolt/test/lit.cfg.py +++ b/bolt/test/lit.cfg.py @@ -18,22 +18,11 @@ from lit.llvm.subst import FindTool # name: The name of this test suite. config.name = "BOLT" -# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites. -# See https://github.com/llvm/llvm-project/issues/106636 for more details. -# -# We prefer the lit internal shell which provides a better user experience on failures -# and is faster unless the user explicitly disables it with LIT_USE_INTERNAL_SHELL=0 -# env var. -use_lit_shell = True -lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL") -if lit_shell_env: - use_lit_shell = lit.util.pythonize_bool(lit_shell_env) - # testFormat: The test format to use to interpret tests. # # For now we require '&&' between commands, until they get globally killed and # the test runner updated. -config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell) +config.test_format = lit.formats.ShTest() # suffixes: A list of file extensions to treat as test files. config.suffixes = [