Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[NFC][SPIR-V] Merge duplicate prefix/suffix switches in lookupBuiltin (#211194)

Browse source
This commit is contained in:
Arseniy Obolenskiy 2026-07-23 06:11:25 +02:00 committed by GitHub
parent 9c52b735ea
commit 90d75e9dde
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
View file

@ -302,9 +302,11 @@ lookupBuiltin(StringRef DemangledCall,
// argument and repeat the search.
if (BuiltinArgumentTypes.size() >= 1) {
char FirstArgumentType = BuiltinArgumentTypes[0][0];
// Prefix to be added to the builtin's name for lookup.
// For example, OpenCL "abs" taking an unsigned value has a prefix "u_".
std::string Prefix;
// Prefix and suffix to be added to the builtin's name for lookup.
// For example, OpenCL "abs" taking an unsigned value has a prefix "u_",
// and "group_reduce_max" taking an unsigned value has a suffix "u".
StringRef Prefix;
StringRef Suffix;
switch (FirstArgumentType) {
// Unsigned:
@ -313,6 +315,7 @@ lookupBuiltin(StringRef DemangledCall,
Prefix = "u_";
else if (Set == SPIRV::InstructionSet::GLSL_std_450)
Prefix = "u";
Suffix = "u";
break;
// Signed:
case 'c':
@ -323,6 +326,7 @@ lookupBuiltin(StringRef DemangledCall,
Prefix = "s_";
else if (Set == SPIRV::InstructionSet::GLSL_std_450)
Prefix = "s";
Suffix = "s";
break;
// Floating-point:
case 'f':
@ -331,43 +335,18 @@ lookupBuiltin(StringRef DemangledCall,
if (Set == SPIRV::InstructionSet::OpenCL_std ||
Set == SPIRV::InstructionSet::GLSL_std_450)
Prefix = "f";
Suffix = "f";
break;
}
// If argument-type name prefix was added, look up the builtin again.
if (!Prefix.empty() &&
(Builtin = SPIRV::lookupBuiltin(Prefix + BuiltinName, Set)))
(Builtin = SPIRV::lookupBuiltin((Prefix + BuiltinName).str(), Set)))
return std::make_unique<SPIRV::IncomingCall>(
BuiltinName, Builtin, ReturnRegister, ReturnType, Arguments);
// If lookup with a prefix failed, find a suffix to be added to the
// builtin's name for lookup. For example, OpenCL "group_reduce_max" taking
// an unsigned value has a suffix "u".
std::string Suffix;
switch (FirstArgumentType) {
// Unsigned:
case 'u':
Suffix = "u";
break;
// Signed:
case 'c':
case 's':
case 'i':
case 'l':
Suffix = "s";
break;
// Floating-point:
case 'f':
case 'd':
case 'h':
Suffix = "f";
break;
}
// If argument-type name suffix was added, look up the builtin again.
if (!Suffix.empty() &&
(Builtin = SPIRV::lookupBuiltin(BuiltinName + Suffix, Set)))
(Builtin = SPIRV::lookupBuiltin((BuiltinName + Suffix).str(), Set)))
return std::make_unique<SPIRV::IncomingCall>(
BuiltinName, Builtin, ReturnRegister, ReturnType, Arguments);
}