Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[OpenMP] Use secure_getenv when read OMPT library path (#208652)

Browse source 
An internal review flagged the use of `getenv` when reading the OMPT
tool library path from the environment and passing it to the loader as a
potential vuln.

This patch replaces the use of getenv in question with the use of
secure_getenv on glibc platforms.
On non glibc platforms, no change is implemented.
This commit is contained in:
Jan Patrick Lehr 2026-07-10 13:25:21 +02:00 committed by GitHub
parent 41a35a7d99
commit 7fcfcf1c5d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
openmp/runtime/src/ompt-general.cpp
View file

@ -60,6 +60,12 @@
static FILE *verbose_file;
static int verbose_init;
#if defined(__GLIBC__)
#define OMPT_GETENV secure_getenv
#else
#define OMPT_GETENV getenv
#endif
/*****************************************************************************
* types
****************************************************************************/
@ -281,7 +287,7 @@ ompt_try_start_tool(unsigned int omp_version, const char *runtime_version) {
// Try tool-libraries-var ICV
OMPT_VERBOSE_INIT_CONTINUED_PRINT("Failed.\n");
const char *tool_libs = getenv("OMP_TOOL_LIBRARIES");
const char *tool_libs = OMPT_GETENV("OMP_TOOL_LIBRARIES");
if (tool_libs) {
OMPT_VERBOSE_INIT_PRINT("Searching tool libraries...\n");
OMPT_VERBOSE_INIT_PRINT("OMP_TOOL_LIBRARIES = %s\n", tool_libs);