Cold-Air-Networks/mirror-llvm-project
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 7

[NFC][clang] Adjust PPMemoryAllocationsTest threshold for ASan (#209024)

Browse source 
PPMemoryAllocationsTest.PPMacroDefinesAllocations measures the memory
footprint of the preprocessor allocator and asserts a strict threshold
of 130.0 bytes per define.

When built with ASan, the allocator adds redzones to allocations,
which increases the total memory reported by `getTotalMemory()` and
causes the test to fail (reporting ~136.8 bytes per define).

Adjust the threshold to 145.0 bytes per define when built with ASan
(detected via `LLVM_ADDRESS_SANITIZER_BUILD`) to account for this
overhead while maintaining the strict limit for standard builds.

Assisted-by: Gemini
This commit is contained in:
Vitaly Buka 2026-07-12 08:19:11 -07:00 committed by GitHub
parent a259ffb45c
commit 7206149c21
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
clang/unittests/Lex/PPMemoryAllocationsTest.cpp
View file

@ -18,6 +18,7 @@
#include "clang/Lex/ModuleLoader.h"
#include "clang/Lex/Preprocessor.h"
#include "clang/Lex/PreprocessorOptions.h"
#include "llvm/Support/Compiler.h"
#include "gtest/gtest.h"
using namespace clang;
@ -89,7 +90,11 @@ TEST_F(PPMemoryAllocationsTest, PPMacroDefinesAllocations) {
// Assume a reasonable upper bound based on that number that we don't want
// to exceed when storing information about a macro #define with 1 or 3
// tokens.
#if LLVM_ADDRESS_SANITIZER_BUILD
EXPECT_LT(BytesPerDefine, 145.0f);
#else
EXPECT_LT(BytesPerDefine, 130.0f);
#endif
}
} // anonymous namespace