From 6f660e269242d51a8d36a9a1f98a2244e8311a1a Mon Sep 17 00:00:00 2001 From: Daniel Paoliello Date: Wed, 16 Jul 2025 09:38:53 -0700 Subject: [PATCH] Fix MSVC warning in benchmark (#147357) Building LLVM with MSVC is raising the following warning: ``` llvm\third-party\benchmark\src\sysinfo.cc(375): warning C4062: enumerator 'CacheUnknown' in switch of enum '_PROCESSOR_CACHE_TYPE' is not handled ``` This change resolves the warning by moving the `Unknown` type into a case block for `CacheUnknown`. Not sure how this code flows back into the original source. --- third-party/benchmark/src/sysinfo.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/third-party/benchmark/src/sysinfo.cc b/third-party/benchmark/src/sysinfo.cc index 3993ae17f7fc..837be8f9cf89 100644 --- a/third-party/benchmark/src/sysinfo.cc +++ b/third-party/benchmark/src/sysinfo.cc @@ -358,7 +358,6 @@ std::vector GetCacheSizesWindows() { C.num_sharing = static_cast(b.count()); C.level = cache.Level; C.size = cache.Size; - C.type = "Unknown"; switch (cache.Type) { case CacheUnified: C.type = "Unified"; @@ -372,6 +371,9 @@ std::vector GetCacheSizesWindows() { case CacheTrace: C.type = "Trace"; break; + case CacheUnknown: + C.type = "Unknown"; + break; } res.push_back(C); }